You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by jcesarmobile <gi...@git.apache.org> on 2016/01/16 11:54:43 UTC
[GitHub] cordova-plugin-inappbrowser pull request: Fix for CB-10305
GitHub user jcesarmobile opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/137
Fix for CB-10305
There are really 3 issues here.
1. When the inAppBrowser is started in portrait and rotates, the
background of the status bar doesn’t fill the whole area. (any iOS
version)
2. On iOS 7, if the inAppBrowser plugin is started on landscape, the
background of the status bar was vertical.
3. On iOS 8-9, on iPhone/iPod, the status bar disappears on landscape,
but the background doesn’t disappear. I’ve changed it to make the
status bar appear on landscape too. (This wasn’t on CB-10305, but I
think it’s related)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jcesarmobile/cordova-plugin-inappbrowser CB-10368
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/137.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #137
----
commit 500de94ae968f77c4545f8e6222eac543caf5ef4
Author: Julio César <jc...@gmail.com>
Date: 2016-01-16T10:45:17Z
Fix for CB-10305
There are really 3 issues here.
1. When the inAppBrowser is started in portrait and rotates, the
background of the status bar doesn’t fill the whole area. (any iOS
version)
2. On iOS 7, if the inAppBrowser plugin is started on landscape, the
background of the status bar was vertical.
3. On iOS 8-9, on iPhone/iPod, the status bar disappears on landscape,
but the background doesn’t disappear. I’ve changed it to make the
status bar appear on landscape too. (This wasn’t on CB-10305, but I
think it’s related)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: Fix for CB-10305
Posted by sgrebnov <gi...@git.apache.org>.
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/137#issuecomment-179900260
I see, merging...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: Fix for CB-10305
Posted by sgrebnov <gi...@git.apache.org>.
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/137#issuecomment-179896028
Is it still actual? - Looks like we have dropped iOS 7.0 support - see CB-9726 Update minimum Deployment Target to iOS 8.0 (https://issues.apache.org/jira/browse/CB-9726)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: Fix for CB-10305
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/137
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: Fix for CB-10305
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/137#issuecomment-179898101
It fix 2 other things that affect iOS 8-9 too.
And don't we have to maintain support for 6 months after deprecating? (not sure if that applies to plugins too)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org