You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "mertdotcc (via GitHub)" <gi...@apache.org> on 2023/03/28 04:34:09 UTC
[GitHub] [camel-k] mertdotcc opened a new issue, #4171: Better naming for Integration phase when fast-jar is enabled
mertdotcc opened a new issue, #4171:
URL: https://github.com/apache/camel-k/issues/4171
This is not an issue/bug per se, but me sharing my observations and opening up a discussion.
Right now when we enable `fast-jar`, we don't give any indication regarding there being 2 images (one native and one non-native) being built. Or when the non-native image is built first and the pod gets deployed but the native image keeps getting built, no indication of that. And finally, when the native image is ready, the promotion from non-native to native happens but we still give no indication of that. (I am referring to `Integration` and `IntegrationKit` phases and not the operator logs.)
Can we bring in 2-3 more integration phases to make these events more verbose and give a better developer experience? [Here](https://github.com/apache/camel-k/blob/6f0037aef8a87d56509f2168cb510cd08d564d46/pkg/apis/camel/v1/integration_types.go#L149) we could add new integration phases such as `BuildingNativeAndNonNative`, `NonNativeIsRunningNativeBuildInProgress`, and `PromotingToNativeImage` - excuse my dreadfully long and uncreative phase suggestions. 🥲
Having such verbose events could technically help with all sorts of metrics and monitoring operations and the end-users wouldn't have to go through the operator logs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] mertdotcc commented on issue #4171: Better naming for Integration phase when fast-jar is enabled
Posted by "mertdotcc (via GitHub)" <gi...@apache.org>.
mertdotcc commented on issue #4171:
URL: https://github.com/apache/camel-k/issues/4171#issuecomment-1486767744
> For the Integration CR this could make sense. More than a Phase, maybe we could think of an additional condition that will help understanding that a pending Native build is ongoing. However it can be technically complex as we need to cascade this change along Build, IntegrationKit and Integration reconcilation cycles.
@squakez I don't think we need to unnecessarily overcomplicate things. I personally don't think that there is any need for an additional condition. Please correct me if I'm wrong or missing a point. The initial idea I had was, having 2-3 extra `Phase` conditions would be enough. (Enough for this multi-image configuration.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] github-actions[bot] commented on issue #4171: Better naming for Integration phase when fast-jar is enabled
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #4171:
URL: https://github.com/apache/camel-k/issues/4171#issuecomment-1608520760
This issue has been automatically marked as stale due to 90 days of inactivity.
It will be closed if no further activity occurs within 15 days.
If you think that’s incorrect or the issue should never stale, please simply write any comment.
Thanks for your contributions!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] christophd commented on issue #4171: Better naming for Integration phase when fast-jar is enabled
Posted by "christophd (via GitHub)" <gi...@apache.org>.
christophd commented on issue #4171:
URL: https://github.com/apache/camel-k/issues/4171#issuecomment-1486364216
I am a bit puzzled. `fast-jar` package type should be the default. The user would need to define both `fast-jar` and `native` package type in order to have the scenario that you describe (arbitrary image is built first and while this is already running the native image get build) am I right?
Besides that +1 on the additional phases. We would need to brainstorm a bit on the naming and what phases to expose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] mertdotcc commented on issue #4171: Better naming for Integration phase when fast-jar is enabled
Posted by "mertdotcc (via GitHub)" <gi...@apache.org>.
mertdotcc commented on issue #4171:
URL: https://github.com/apache/camel-k/issues/4171#issuecomment-1486761133
> I am a bit puzzled. fast-jar package type should be the default. The user would need to define both fast-jar and native package type in order to have the scenario that you describe (arbitrary image is built first and while this is already running the native image get build) am I right?
@christophd you are right, the `quarkus` part of my `kamel run` command looks exactly like this:
```
--trait quarkus.enabled=true \
--trait quarkus.package-type=fast-jar \
--trait quarkus.package-type=native \
```
and this is something we use quite often. Developer pushes the code, the JVM image gets built and deployed within seconds, `YAKS` and some `iter8` tests run and generate the test results, then finally the native image is built and deployed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on issue #4171: Better naming for Integration phase when fast-jar is enabled
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on issue #4171:
URL: https://github.com/apache/camel-k/issues/4171#issuecomment-1486361470
For the Integration CR this could make sense. More than a Phase, maybe we could think of an additional condition that will help understanding that a pending Native build is ongoing. However it can be technically complex as we need to cascade this change along Build, IntegrationKit and Integration reconcilation cycles.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] github-actions[bot] closed issue #4171: Better naming for Integration phase when fast-jar is enabled
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #4171: Better naming for Integration phase when fast-jar is enabled
URL: https://github.com/apache/camel-k/issues/4171
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on issue #4171: Better naming for Integration phase when fast-jar is enabled
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on issue #4171:
URL: https://github.com/apache/camel-k/issues/4171#issuecomment-1486369511
Let's also keep in mind that this would be specific of Camel Quarkus runtime. As we're talking to onboard any Camel runtime, the phases should be agnostic of the runtime details (native would be exclusive of the Camel Quarkus runtime). This is vaguely related to #4166 as we're planning to make trait also not dependent of runtime details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org