You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/06/07 05:23:31 UTC
[GitHub] [incubator-echarts] softwords opened a new issue #12763: Minor problems with sankey.d.ts
softwords opened a new issue #12763:
URL: https://github.com/apache/incubator-echarts/issues/12763
### Version
4.8.0
### Steps to reproduce
Some problems in typescript definitions `@types\echarts` (v4.6.1) for sankey series cause compilation errors in typescript:
`name` is missing - this causes problems even when not working with sankey chart.
`nodeAlign` is missing
`links` is defined as a single link object - should be an array of such objects
### What is expected?
These snippets should compile:
1)
```
let option:echarts:EChartOption = { };
let seriesNames = option.series.map(s => s.name);
```
2)
```
let series: echarts.EChartOption.SeriesSankey = {
type: 'sankey',
focusNodeAdjacency: 'allEdges',
data: [{
name: 'a'
}, {
name: 'b'
}, {
name: 'a1'
}, {
name: 'a2'
}, {
name: 'b1'
}, {
name: 'c'
}],
links: [{
source: 'a',
target: 'a1',
value: 5
}, {
source: 'a',
target: 'a2',
value: 3
}, {
source: 'b',
target: 'b1',
value: 8
}, {
source: 'a',
target: 'b1',
value: 3
}, {
source: 'b1',
target: 'a1',
value: 1
}, {
source: 'b1',
target: 'c',
value: 2
}]
};
```
### What is actually happening?
1)
compilation error:
```
Property 'name' does not exist on type 'Series'.
Property 'name' does not exist on type 'SeriesSankey'.
```
2)
compilation error:
```
error TS2559: Type '{ source: string; target: string; value: number; }[]'
has no properties in common with type
'{ source?: string; target?: string; value?: number; lineStyle?: { color?: string; opacity?:
number; curveness?: number; shadowBlur?: number; shadowColor?: string; shadowOffsetX?: number; shadowOffsetY?: number; }; emphasis?: { ...; }; }'.
```
---
Not sure if this is the right place to report this, since the issue is in the echarts .d.ts files, not echarts itself....
<!-- This issue is generated by echarts-issue-helper. DO NOT REMOVE -->
<!-- This issue is in English. DO NOT REMOVE -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #12763: Minor problems with sankey.d.ts
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on issue #12763:
URL: https://github.com/apache/incubator-echarts/issues/12763#issuecomment-640159329
Hi! We've received your issue and please be patient to get responded. 🎉
The average response time is expected to be within one day for weekdays.
In the meanwhile, please make sure that **you have posted enough image to demo your request**. You may also check out the [API](http://echarts.apache.org/api.html) and [chart option](http://echarts.apache.org/option.html) to get the answer.
If you don't get helped for a long time (over a week) or have an urgent question to ask, you may also send an email to dev@echarts.apache.org. Please attach the issue link if it's a technical questions.
If you are interested in the project, you may also subscribe our [mail list](https://echarts.apache.org/en/maillist.html).
Have a nice day! 🍵
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] Ovilia commented on issue #12763: Minor problems with sankey.d.ts
Posted by GitBox <gi...@apache.org>.
Ovilia commented on issue #12763:
URL: https://github.com/apache/incubator-echarts/issues/12763#issuecomment-643027844
Thanks! I will close the issue here. If you have more questions with the PR, we can discuss there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] softwords commented on issue #12763: Minor problems with sankey.d.ts
Posted by GitBox <gi...@apache.org>.
softwords commented on issue #12763:
URL: https://github.com/apache/incubator-echarts/issues/12763#issuecomment-640571759
@Ovilia thankyou for your prompt reply. I have created a PR in DefinitelyTyped as you suggested,
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] Ovilia closed issue #12763: Minor problems with sankey.d.ts
Posted by GitBox <gi...@apache.org>.
Ovilia closed issue #12763:
URL: https://github.com/apache/incubator-echarts/issues/12763
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] Ovilia commented on issue #12763: Minor problems with sankey.d.ts
Posted by GitBox <gi...@apache.org>.
Ovilia commented on issue #12763:
URL: https://github.com/apache/incubator-echarts/issues/12763#issuecomment-640326534
If this is caused by the type definition under DefinitelyTyped, a simple fix would be changing it to as any. You may also make a pull request to that project if you wish.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org