You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudberry.apache.org by "ostinru (via GitHub)" <gi...@apache.org> on 2025/12/22 09:31:50 UTC
[PR] Autmation: update pipeline & fix hive file copy [cloudberry-pxf]
ostinru opened a new pull request, #20:
URL: https://github.com/apache/cloudberry-pxf/pull/20
This PR consist of two changes:
1. Update CI pipeline to mark steps failed when we have failed/skipped tests
2. Fix Hive tests, by fixing file copy check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Autmation: update pipeline & fix hive file copy [cloudberry-pxf]
Posted by "ostinru (via GitHub)" <gi...@apache.org>.
ostinru commented on PR #20:
URL: https://github.com/apache/cloudberry-pxf/pull/20#issuecomment-3681231577
@tuhaihe , should I sign CLA Agreement? Commit message template says that I should. However there is no description on how this process organized.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Autmation: update pipeline & fix hive file copy [cloudberry-pxf]
Posted by "ostinru (via GitHub)" <gi...@apache.org>.
ostinru commented on code in PR #20:
URL: https://github.com/apache/cloudberry-pxf/pull/20#discussion_r2642193591
##########
.github/workflows/pxf-ci.yml:
##########
@@ -249,8 +253,11 @@ jobs:
- name: Check test result
if: always()
run: |
- if [ "${{ steps.run_test.outcome }}" == "failure" ]; then
- echo "Test group ${{ matrix.test_group }} failed"
+ FAILED_COUNT="${{ steps.collect_artifacts.outputs.failed_count || 0 }}"
+ SKIPPED_COUNT="${{ steps.collect_artifacts.outputs.skipped_count || 0 }}"
+
+ if [ "${{ steps.run_test.outcome }}" == "failure" ] || [ "$FAILED_COUNT" -gt 0 ] || [ "$SKIPPED_COUNT" -gt 0 ]; then
Review Comment:
Sometimes it marks tests as skipped due to unavailability of some `jsystem`'s resources.
Let me check it again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Autmation: update pipeline & fix hive file copy [cloudberry-pxf]
Posted by "ostinru (via GitHub)" <gi...@apache.org>.
ostinru commented on code in PR #20:
URL: https://github.com/apache/cloudberry-pxf/pull/20#discussion_r2647228949
##########
.github/workflows/pxf-ci.yml:
##########
@@ -249,8 +253,11 @@ jobs:
- name: Check test result
if: always()
run: |
- if [ "${{ steps.run_test.outcome }}" == "failure" ]; then
- echo "Test group ${{ matrix.test_group }} failed"
+ FAILED_COUNT="${{ steps.collect_artifacts.outputs.failed_count || 0 }}"
+ SKIPPED_COUNT="${{ steps.collect_artifacts.outputs.skipped_count || 0 }}"
+
+ if [ "${{ steps.run_test.outcome }}" == "failure" ] || [ "$FAILED_COUNT" -gt 0 ] || [ "$SKIPPED_COUNT" -gt 0 ]; then
Review Comment:
Reorganised my commits: one commit - one fix. Should be easies to review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Autmation: update pipeline & fix hive file copy [cloudberry-pxf]
Posted by "MisterRaindrop (via GitHub)" <gi...@apache.org>.
MisterRaindrop commented on code in PR #20:
URL: https://github.com/apache/cloudberry-pxf/pull/20#discussion_r2641832751
##########
.github/workflows/pxf-ci.yml:
##########
@@ -249,8 +253,11 @@ jobs:
- name: Check test result
if: always()
run: |
- if [ "${{ steps.run_test.outcome }}" == "failure" ]; then
- echo "Test group ${{ matrix.test_group }} failed"
+ FAILED_COUNT="${{ steps.collect_artifacts.outputs.failed_count || 0 }}"
+ SKIPPED_COUNT="${{ steps.collect_artifacts.outputs.skipped_count || 0 }}"
+
+ if [ "${{ steps.run_test.outcome }}" == "failure" ] || [ "$FAILED_COUNT" -gt 0 ] || [ "$SKIPPED_COUNT" -gt 0 ]; then
Review Comment:
SKIPPED_COUNT > 0 is failed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Autmation: update pipeline & fix hive file copy [cloudberry-pxf]
Posted by "tuhaihe (via GitHub)" <gi...@apache.org>.
tuhaihe merged PR #20:
URL: https://github.com/apache/cloudberry-pxf/pull/20
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Autmation: update pipeline & fix hive file copy [cloudberry-pxf]
Posted by "MisterRaindrop (via GitHub)" <gi...@apache.org>.
MisterRaindrop commented on code in PR #20:
URL: https://github.com/apache/cloudberry-pxf/pull/20#discussion_r2646646900
##########
.github/workflows/pxf-ci.yml:
##########
@@ -249,8 +253,11 @@ jobs:
- name: Check test result
if: always()
run: |
- if [ "${{ steps.run_test.outcome }}" == "failure" ]; then
- echo "Test group ${{ matrix.test_group }} failed"
+ FAILED_COUNT="${{ steps.collect_artifacts.outputs.failed_count || 0 }}"
+ SKIPPED_COUNT="${{ steps.collect_artifacts.outputs.skipped_count || 0 }}"
+
+ if [ "${{ steps.run_test.outcome }}" == "failure" ] || [ "$FAILED_COUNT" -gt 0 ] || [ "$SKIPPED_COUNT" -gt 0 ]; then
Review Comment:
It looks complicated. Please let me know when you're ready for the review. I will review the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Autmation: update pipeline & fix hive file copy [cloudberry-pxf]
Posted by "ostinru (via GitHub)" <gi...@apache.org>.
ostinru commented on code in PR #20:
URL: https://github.com/apache/cloudberry-pxf/pull/20#discussion_r2645825338
##########
.github/workflows/pxf-ci.yml:
##########
@@ -249,8 +253,11 @@ jobs:
- name: Check test result
if: always()
run: |
- if [ "${{ steps.run_test.outcome }}" == "failure" ]; then
- echo "Test group ${{ matrix.test_group }} failed"
+ FAILED_COUNT="${{ steps.collect_artifacts.outputs.failed_count || 0 }}"
+ SKIPPED_COUNT="${{ steps.collect_artifacts.outputs.skipped_count || 0 }}"
+
+ if [ "${{ steps.run_test.outcome }}" == "failure" ] || [ "$FAILED_COUNT" -gt 0 ] || [ "$SKIPPED_COUNT" -gt 0 ]; then
Review Comment:
Ok... It in fact more complicated than I thought before.
Old TestNG versions has bug https://github.com/testng-team/testng/issues/739 - when `@BeforeClass(alwaysRun = true)` fails - all tests are marked as SKIPPED despite of `alwaysRun = true`. Fixed in 6.9.5+.
Originally, almost all tests in open-gpdb/pxf failed somwhere inside `doInit()` methods - and all our tests were marked as SKIPPED. And then we decided to think about such tests as FAILED.
So, it seems we can just bump testng version. In this scenario I will expect that tests will be FAILED instead of SKIPPED. I will update this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Autmation: update pipeline & fix hive file copy [cloudberry-pxf]
Posted by "tuhaihe (via GitHub)" <gi...@apache.org>.
tuhaihe commented on PR #20:
URL: https://github.com/apache/cloudberry-pxf/pull/20#issuecomment-3681254637
> @tuhaihe , should I sign CLA Agreement? Commit message template says that I should. However there is no description on how this process organized.
Hey @ostinru there is no need to sign it under the ASF repos. Sorry for the confusion...
I will update the related files following the ASF policies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org