You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by sa...@apache.org on 2018/01/03 17:20:12 UTC

incubator-airflow git commit: [AIRFLOW-1967] Update Celery to 4.0.2

Repository: incubator-airflow
Updated Branches:
  refs/heads/master fbeb8f0a0 -> b9f4a7437


[AIRFLOW-1967] Update Celery to 4.0.2

Update Celery to 4.0.2 for fixing error
TypeError: '<=' not supported between instances of
'NoneType' and 'int'

Hi all,

I'd like to update Celery to version 4.0.2. While
updating my Docker container to version 1.9, I
caught this error:
```
worker_1     | [2018-01-03 10:34:29,934:
CRITICAL/MainProcess] Unrecoverable error:
TypeError("'<=' not supported between instances of
'NoneType' and 'int'",)
worker_1     | Traceback (most recent call last):
worker_1     |   File "/usr/local/lib/python3.6
/site-packages/celery/worker/worker.py", line 203,
in start
worker_1     |     self.blueprint.start(self)
worker_1     |   File "/usr/local/lib/python3.6
/site-packages/celery/bootsteps.py", line 115, in
start
worker_1     |     self.on_start()
worker_1     |   File "/usr/local/lib/python3.6
/site-packages/celery/apps/worker.py", line 143,
in on_start
worker_1     |     self.emit_banner()
worker_1     |   File "/usr/local/lib/python3.6
/site-packages/celery/apps/worker.py", line 159,
in emit_banner
worker_1     |
string(self.colored.reset(self.extra_info() or
'')),
worker_1     |   File "/usr/local/lib/python3.6
/site-packages/celery/apps/worker.py", line 188,
in extra_info
worker_1     |     if self.loglevel <=
logging.INFO:
worker_1     | TypeError: '<=' not supported
between instances of 'NoneType' and 'int'
```

This is because I've been running Python 2 in my
local environments, and the Docker image is Python
3:
https://github.com/puckel/docker-
airflow/pull/143/files

This is the issue in Celery:
https://github.com/celery/celery/blob/0dde9df9d8dd
5dbbb97ef75a81757bc2d9a4b33e/Changelog#L145

Make sure you have checked _all_ steps below.

### JIRA
- [x] My PR addresses the following [Airflow JIRA]
(https://issues.apache.org/jira/browse/AIRFLOW/)
issues and references them in the PR title. For
example, "[AIRFLOW-XXX] My Airflow PR"
    - https://issues.apache.org/jira/browse/AIRFLOW-
XXX

### Description
- [x] Here are some details about my PR, including
screenshots of any UI changes:

### Tests
- [x] My PR adds the following unit tests __OR__
does not need testing for this extremely good
reason:

### Commits
- [x] My commits all reference JIRA issues in
their subject lines, and I have squashed multiple
commits if they address the same issue. In
addition, my commits follow the guidelines from
"[How to write a good git commit
message](http://chris.beams.io/posts/git-
commit/)":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not
"adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

- [x] Passes `git diff upstream/master -u --
"*.py" | flake8 --diff`

Closes #2914 from Fokko/AIRFLOW-1967-update-celery


Project: http://git-wip-us.apache.org/repos/asf/incubator-airflow/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-airflow/commit/b9f4a743
Tree: http://git-wip-us.apache.org/repos/asf/incubator-airflow/tree/b9f4a743
Diff: http://git-wip-us.apache.org/repos/asf/incubator-airflow/diff/b9f4a743

Branch: refs/heads/master
Commit: b9f4a7437e4228ec15c94ddaae55be9b7d92ef8f
Parents: fbeb8f0
Author: Fokko Driesprong <fo...@godatadriven.com>
Authored: Wed Jan 3 09:20:00 2018 -0800
Committer: Siddharth Anand <si...@yahoo.com>
Committed: Wed Jan 3 09:20:00 2018 -0800

----------------------------------------------------------------------
 setup.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-airflow/blob/b9f4a743/setup.py
----------------------------------------------------------------------
diff --git a/setup.py b/setup.py
index f270dba..84da6f1 100644
--- a/setup.py
+++ b/setup.py
@@ -98,7 +98,7 @@ async = [
 azure = ['azure-storage>=0.34.0']
 sendgrid = ['sendgrid>=5.2.0']
 celery = [
-    'celery>=4.0.0',
+    'celery>=4.0.2',
     'flower>=0.7.3'
 ]
 cgroups = [