You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by ol...@apache.org on 2017/10/16 11:49:49 UTC

httpcomponents-client git commit: Fixed NPE in case of a missing Max-Forwards header

Repository: httpcomponents-client
Updated Branches:
  refs/heads/4.5.x ad606e45b -> cfbbea0ee


Fixed NPE in case of a missing Max-Forwards header


Project: http://git-wip-us.apache.org/repos/asf/httpcomponents-client/repo
Commit: http://git-wip-us.apache.org/repos/asf/httpcomponents-client/commit/cfbbea0e
Tree: http://git-wip-us.apache.org/repos/asf/httpcomponents-client/tree/cfbbea0e
Diff: http://git-wip-us.apache.org/repos/asf/httpcomponents-client/diff/cfbbea0e

Branch: refs/heads/4.5.x
Commit: cfbbea0ee3ee90590106aa906eec5e9864b9a24c
Parents: ad606e4
Author: Oleg Kalnichevski <ol...@apache.org>
Authored: Sun Oct 15 13:29:59 2017 +0200
Committer: Oleg Kalnichevski <ol...@apache.org>
Committed: Mon Oct 16 13:49:31 2017 +0200

----------------------------------------------------------------------
 .../org/apache/http/impl/client/cache/CachingHttpClient.java      | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/httpcomponents-client/blob/cfbbea0e/httpclient-cache/src/main/java-deprecated/org/apache/http/impl/client/cache/CachingHttpClient.java
----------------------------------------------------------------------
diff --git a/httpclient-cache/src/main/java-deprecated/org/apache/http/impl/client/cache/CachingHttpClient.java b/httpclient-cache/src/main/java-deprecated/org/apache/http/impl/client/cache/CachingHttpClient.java
index 20f54cf..a564dc1 100644
--- a/httpclient-cache/src/main/java-deprecated/org/apache/http/impl/client/cache/CachingHttpClient.java
+++ b/httpclient-cache/src/main/java-deprecated/org/apache/http/impl/client/cache/CachingHttpClient.java
@@ -748,7 +748,8 @@ public class CachingHttpClient implements HttpClient {
             return false;
         }
 
-        if (!"0".equals(request.getFirstHeader(HeaderConstants.MAX_FORWARDS).getValue())) {
+        final Header h = request.getFirstHeader(HeaderConstants.MAX_FORWARDS);
+        if (!"0".equals(h != null ? h.getValue() : null)) {
             return false;
         }