You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/07/07 20:10:13 UTC

[GitHub] [kafka] cmccabe commented on pull request #10992: MINOR: Remove nullable from addingReplicas and removingReplicas

cmccabe commented on pull request #10992:
URL: https://github.com/apache/kafka/pull/10992#issuecomment-875898150


   Thanks, @mumrah !
   
   Can you use `Replicas.EMPTY` instead of `new int[0]`? It saves an allocation.
   
   LGTM after that


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org