You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Mike Percy <mp...@apache.org> on 2013/05/01 08:09:12 UTC
Review Request: FLUME-2002: Flume RPC Client creates 2 threads per each log
attempt if the remote flume agent goes down
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10880/
-----------------------------------------------------------
Review request for Flume.
Description
-------
Shut down thread pools on failure to connect.
This addresses bug FLUME-2002.
https://issues.apache.org/jira/browse/FLUME-2002
Diffs
-----
flume-ng-sdk/src/main/java/org/apache/flume/api/NettyAvroRpcClient.java 8285129
flume-ng-sdk/src/test/java/org/apache/flume/api/TestNettyAvroRpcClient.java 1e6d2b2
Diff: https://reviews.apache.org/r/10880/diff/
Testing
-------
Added unit test.
Thanks,
Mike Percy
Re: Review Request: FLUME-2002: Flume RPC Client creates 2 threads per each
log attempt if the remote flume agent goes down
Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10880/#review20006
-----------------------------------------------------------
Ship it!
Ship It!
- Hari Shreedharan
On May 1, 2013, 6:09 a.m., Mike Percy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10880/
> -----------------------------------------------------------
>
> (Updated May 1, 2013, 6:09 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Shut down thread pools on failure to connect.
>
>
> This addresses bug FLUME-2002.
> https://issues.apache.org/jira/browse/FLUME-2002
>
>
> Diffs
> -----
>
> flume-ng-sdk/src/main/java/org/apache/flume/api/NettyAvroRpcClient.java 8285129
> flume-ng-sdk/src/test/java/org/apache/flume/api/TestNettyAvroRpcClient.java 1e6d2b2
>
> Diff: https://reviews.apache.org/r/10880/diff/
>
>
> Testing
> -------
>
> Added unit test.
>
>
> Thanks,
>
> Mike Percy
>
>
Re: Review Request: FLUME-2002: Flume RPC Client creates 2 threads per each
log attempt if the remote flume agent goes down
Posted by of...@gmail.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10880/#review20195
-----------------------------------------------------------
Line 144-152 -- Does the state need to be set to something different before throwing/rethrowing an exception?
- offbynull
On May 1, 2013, 6:09 a.m., Mike Percy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10880/
> -----------------------------------------------------------
>
> (Updated May 1, 2013, 6:09 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Shut down thread pools on failure to connect.
>
>
> This addresses bug FLUME-2002.
> https://issues.apache.org/jira/browse/FLUME-2002
>
>
> Diffs
> -----
>
> flume-ng-sdk/src/main/java/org/apache/flume/api/NettyAvroRpcClient.java 8285129
> flume-ng-sdk/src/test/java/org/apache/flume/api/TestNettyAvroRpcClient.java 1e6d2b2
>
> Diff: https://reviews.apache.org/r/10880/diff/
>
>
> Testing
> -------
>
> Added unit test.
>
>
> Thanks,
>
> Mike Percy
>
>
Re: Review Request: FLUME-2002: Flume RPC Client creates 2 threads per each
log attempt if the remote flume agent goes down
Posted by Edward Sargisson <es...@pobox.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10880/#review20004
-----------------------------------------------------------
I've taken a look and it looks good to me. I'm hoping a colleague may take a look as well.
- Edward Sargisson
On May 1, 2013, 6:09 a.m., Mike Percy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10880/
> -----------------------------------------------------------
>
> (Updated May 1, 2013, 6:09 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Shut down thread pools on failure to connect.
>
>
> This addresses bug FLUME-2002.
> https://issues.apache.org/jira/browse/FLUME-2002
>
>
> Diffs
> -----
>
> flume-ng-sdk/src/main/java/org/apache/flume/api/NettyAvroRpcClient.java 8285129
> flume-ng-sdk/src/test/java/org/apache/flume/api/TestNettyAvroRpcClient.java 1e6d2b2
>
> Diff: https://reviews.apache.org/r/10880/diff/
>
>
> Testing
> -------
>
> Added unit test.
>
>
> Thanks,
>
> Mike Percy
>
>