You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Qingsheng Ren (Jira)" <ji...@apache.org> on 2022/09/13 02:21:00 UTC

[jira] [Comment Edited] (FLINK-29153) KafkaConsumerThread should catch WakeupException when committing offsets

    [ https://issues.apache.org/jira/browse/FLINK-29153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602076#comment-17602076 ] 

Qingsheng Ren edited comment on FLINK-29153 at 9/13/22 2:20 AM:
----------------------------------------------------------------

Fixed on master: 3e883e687d2bdb80ad2f160b08184fca11f4f554

release-1.16: dbcf949f89b5bead6c2bec4de77ca68bc8614fe6


was (Author: renqs):
Fixed on master: 3e883e687d2bdb80ad2f160b08184fca11f4f554

> KafkaConsumerThread should catch WakeupException when committing offsets
> ------------------------------------------------------------------------
>
>                 Key: FLINK-29153
>                 URL: https://issues.apache.org/jira/browse/FLINK-29153
>             Project: Flink
>          Issue Type: Bug
>          Components: Connectors / Kafka
>    Affects Versions: 1.16.0
>            Reporter: Qingsheng Ren
>            Assignee: Qingsheng Ren
>            Priority: Critical
>              Labels: pull-request-available
>             Fix For: 1.16.0
>
>
> {{KafkaConsumerThread}} in the legacy {{FlinkKafkaConsumer}} makes a wakeup on the {{KafkaConsumer}} on offset commit to wakeup the potential blocking {{KafkaConsumer.poll()}}. However the wakeup might happen when the consumer is not polling. The wakeup will be remembered by the consumer and re-examined while committing the offset asynchronously, which leads to an unnecessary {{WakeupException}}. 
> As the JavaDoc and method signature of KafkaConsumer does not show that the WakeupException could be thrown in KafkaConsumer#commitAsync, this could be considered as a bug on Kafka side (breaking the contract of public API), but we can still fix it by catching the WakeupException and retrying. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)