You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/07/18 11:45:16 UTC
[GitHub] [incubator-nuttx] no1wudi opened a new pull request #4172: sched: Remove unused TLS member from task_group_s
no1wudi opened a new pull request #4172:
URL: https://github.com/apache/incubator-nuttx/pull/4172
## Summary
Remove tg_tlsset and tg_tlsdestr since them had been moved to task_info_s.
## Impact
None
## Testing
Tested with sabrelite (qemu).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] no1wudi commented on a change in pull request #4172: sched: Remove unused TLS member from task_group_s
Posted by GitBox <gi...@apache.org>.
no1wudi commented on a change in pull request #4172:
URL: https://github.com/apache/incubator-nuttx/pull/4172#discussion_r671839781
##########
File path: include/nuttx/sched.h
##########
@@ -537,12 +537,6 @@ struct task_group_s
FAR struct task_info_s *tg_info;
-#if CONFIG_TLS_NELEM > 0
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #4172: sched: Remove unused TLS member from task_group_s
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #4172:
URL: https://github.com/apache/incubator-nuttx/pull/4172#discussion_r671830568
##########
File path: include/nuttx/sched.h
##########
@@ -537,12 +537,6 @@ struct task_group_s
FAR struct task_info_s *tg_info;
-#if CONFIG_TLS_NELEM > 0
Review comment:
let's move to tls.h too:
```
/* type tls_ndxset_t & tls_dtor_t *******************************************/
/* Smallest addressable type that can hold the entire configured number of
* TLS data indexes.
*/
#if CONFIG_TLS_NELEM > 0
# if CONFIG_TLS_NELEM > 32
# error Too many TLS elements
# elif CONFIG_TLS_NELEM > 16
typedef uint32_t tls_ndxset_t;
# elif CONFIG_TLS_NELEM > 8
typedef uint16_t tls_ndxset_t;
# else
typedef uint8_t tls_ndxset_t;
# endif
typedef CODE void (*tls_dtor_t)(FAR void *);
#endif
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #4172: sched: Remove unused TLS member from task_group_s
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #4172:
URL: https://github.com/apache/incubator-nuttx/pull/4172
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #4172: sched: Remove unused TLS member from task_group_s
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #4172:
URL: https://github.com/apache/incubator-nuttx/pull/4172
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #4172: sched: Remove unused TLS member from task_group_s
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #4172:
URL: https://github.com/apache/incubator-nuttx/pull/4172
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org