[GitHub] [incubator-seatunnel] Hisoka-X commented on a diff in pull request #3946: [Feature][Zeta] Add Zeta Client ShutdownHook To Cancel Job

[GitBox <gi...@apache.org>]

Hisoka-X commented on code in PR #3946:
URL: https://github.com/apache/incubator-seatunnel/pull/3946#discussion_r1070752770


##########
seatunnel-core/seatunnel-starter/src/main/java/org/apache/seatunnel/core/starter/seatunnel/command/ClientExecuteCommand.java:
##########
@@ -176,4 +179,9 @@ private String creatRandomClusterName(String namePrefix) {
         return namePrefix + "-" + random.nextInt(1000000);
     }
 
+    private void shutdownHook(ClientJobProxy clientJobProxy) {
+        log.warn("Task will be closed due to client shutdown.");

Review Comment:
   If job already return status to client, mean job already done, seem like we shouldn't execute cancel job.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org