You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by mb...@apache.org on 2012/06/08 14:50:38 UTC
svn commit: r1348048 -
/hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/master/RegionManager.java
Author: mbautin
Date: Fri Jun 8 12:50:37 2012
New Revision: 1348048
URL: http://svn.apache.org/viewvc?rev=1348048&view=rev
Log:
[master] fix some confusing log output during region assignment
Author: pkhemani
Summary:
example of confusing log
2012-06-07 11:46:01,179 INFO org.apache.hadoop.hbase.master.RegionManager: Assigning region MailBox_junnischema,63b48c1e,1316555313354.8be80ae5b92d8eacae3747d66d0c6db4. to msgstore203.ash2.facebook.com,60020,1339094759543
2012-06-07 11:46:01,994 DEBUG org.apache.hadoop.hbase.master.RegionManager: Doing Preferred Region Assignment for : MailBox_junnischema:8be80ae5b92d8eacae3747d66d0c6db4 to the msgstore280.ash2.facebook.com
2012-06-07 11:46:02,289 INFO org.apache.hadoop.hbase.master.ServerManager: Processing MSG_REPORT_PROCESS_OPEN: MailBox_junnischema,63b48c1e,1316555313354.8be80ae5b92d8eacae3747d66d0c6db4. from msgstore203.ash2.facebook.com,60020,1339094759543; 1 of 21
Test Plan: none
Reviewers: liyintang
Reviewed By: liyintang
CC: hbase-eng@, kannan
Differential Revision: https://phabricator.fb.com/D489148
Modified:
hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/master/RegionManager.java
Modified: hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/master/RegionManager.java
URL: http://svn.apache.org/viewvc/hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/master/RegionManager.java?rev=1348048&r1=1348047&r2=1348048&view=diff
==============================================================================
--- hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/master/RegionManager.java (original)
+++ hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/master/RegionManager.java Fri Jun 8 12:50:37 2012
@@ -714,6 +714,9 @@ public class RegionManager {
synchronized (this.regionsInTransition) {
for (RegionState s : regionsInTransition.values()) {
+ if (! s.isUnassigned()) {
+ continue;
+ }
String regionName = s.getRegionInfo().getEncodedName();
String tableName = s.getRegionInfo().getTableDesc().getNameAsString();
String name = tableName + ":" + regionName;
@@ -750,9 +753,7 @@ public class RegionManager {
LOG.debug("Doing Preferred Region Assignment for : " + name +
" to the " + hostName);
// add the region to its preferred region server.
- if (s.isUnassigned()) {
- regionsToAssign.add(s);
- }
+ regionsToAssign.add(s);
continue;
} else if (holdRegionForBestRegionserver ||
quickStartRegionServerSet.contains(preferredHost)) {
@@ -762,8 +763,7 @@ public class RegionManager {
}
// Only assign a configured number unassigned region at one time in the
// non preferred assignment case.
- if (s.isUnassigned() &&
- (nonPreferredAssignmentCount++) < this.maxAssignInOneGo) {
+ if ((nonPreferredAssignmentCount++) < this.maxAssignInOneGo) {
regionsToAssign.add(s);
}
}