You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by bennetelli <gi...@git.apache.org> on 2017/01/01 15:38:49 UTC
[GitHub] activemq-artemis pull request #944: ARTEMIS-904 - Remove cyclic dependencies...
GitHub user bennetelli opened a pull request:
https://github.com/apache/activemq-artemis/pull/944
ARTEMIS-904 - Remove cyclic dependencies from artemis-cli
To ensure a maintainability in future I refactored the cli project and removed all cyclic dependencies between classes and packages by moving classes and packages near to their real responsibility and reduced access modifiers after it. (I can show you a "before and after" picture of the projects architecture from a package point of view if you want.)
I tried to move classes and methods only and reduced visibility of methods. Didn't change other stuff like unused methods and so on.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bennetelli/activemq-artemis entangling-artemis-cli
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/944.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #944
----
commit 47bc644315ff86d07e409d25ef2aab1511000b65
Author: Bennet Schulz <ma...@bennet-schulz.de>
Date: 2016-12-31T13:56:03Z
ARTEMIS-903 Add documentation for updating Artemis to newer versions
Currently there is no documentation about updating ActiveMQ Artemis in the Artemis user manual. This commit adds a brief description of the steps necessary to update Artemis to newer versions.
commit fdf14bc57bd85aef28fa277a48f20505a113f728
Author: Bennet Schulz <ma...@bennet-schulz.de>
Date: 2017-01-01T12:10:43Z
ARTEMIS-903 Add documentation for updating Artemis to newer versions
Add reference to "updating Artemis" section in summary of user manual
commit 569e457b3703285e12b7d94ccc1cdb5c540bf895
Author: Bennet Schulz <ma...@bennet-schulz.de>
Date: 2017-01-01T15:37:04Z
ARTEMIS-904 - Remove cyclic dependencies from artemis-cli
To ensure a maintainability in future I refactored the cli project and removed all cyclic dependencies between classes and packages by moving classes and packages near to their real responsibility and reduced access modifiers after it. (I can show you a "before and after" picture of the projects architecture from a package point of view if you want.)
I tried to move classes and methods only and reduced visibility of methods. Didn't change other stuff like unused methods and so on.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #944: ARTEMIS-904 - Remove cyclic dependencies from a...
Posted by bennetelli <gi...@git.apache.org>.
Github user bennetelli commented on the issue:
https://github.com/apache/activemq-artemis/pull/944
sh**. Created the branch from my previous ARTEMIS-903 branch. Would be good if we could close the second one (ARTEMIS-904) and I will open a new PR later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #944: ARTEMIS-904 - Remove cyclic dependencies...
Posted by bennetelli <gi...@git.apache.org>.
Github user bennetelli closed the pull request at:
https://github.com/apache/activemq-artemis/pull/944
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #944: ARTEMIS-904 - Remove cyclic dependencies from a...
Posted by johnament <gi...@git.apache.org>.
Github user johnament commented on the issue:
https://github.com/apache/activemq-artemis/pull/944
You'll need to close it. Here's a link to the checkstyle issues https://builds.apache.org/job/ActiveMQ-Artemis-PR-Build/2113/consoleFull
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #944: ARTEMIS-904 - Remove cyclic dependencies from a...
Posted by bennetelli <gi...@git.apache.org>.
Github user bennetelli commented on the issue:
https://github.com/apache/activemq-artemis/pull/944
@clebertsuconic argh. Thought another branch would result in a separate pull request. Let me know if you have trouble with it :/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #944: ARTEMIS-904 - Remove cyclic dependencies from a...
Posted by bennetelli <gi...@git.apache.org>.
Github user bennetelli commented on the issue:
https://github.com/apache/activemq-artemis/pull/944
Can't find any checkstyle warnings. Where are you looking for it?
The Jenkins build failed because of an error in LDAP stuff which I didn't touch with my new markdown documentation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #944: ARTEMIS-904 - Remove cyclic dependencies from a...
Posted by johnament <gi...@git.apache.org>.
Github user johnament commented on the issue:
https://github.com/apache/activemq-artemis/pull/944
Also it looks like you have two PRs with the same changes now. We should merge one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #944: ARTEMIS-904 - Remove cyclic dependencies from a...
Posted by johnament <gi...@git.apache.org>.
Github user johnament commented on the issue:
https://github.com/apache/activemq-artemis/pull/944
Looks like some checkstyle issues in the CLI module, if you could fix those up.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---