You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by "rahulrane50 (via GitHub)" <gi...@apache.org> on 2023/05/24 18:52:27 UTC

[GitHub] [helix] rahulrane50 commented on a diff in pull request #2504: Fix test failure: TestZkCacheAsyncOpSingleThread

rahulrane50 commented on code in PR #2504:
URL: https://github.com/apache/helix/pull/2504#discussion_r1204631874


##########
helix-core/src/test/java/org/apache/helix/manager/zk/TestZkCacheAsyncOpSingleThread.java:
##########
@@ -174,15 +174,14 @@ public void testHappyPathExtOpZkCacheBaseDataAccessor() throws Exception {
 
     // wait zkEventThread update zkCache
     // verify wtCache
-    for (int i = 0; i < 10; i++) {
+    for (int i = 0; i < 20; i++) {

Review Comment:
   We can also run this test 20 times and see if t really fixes the flaky test.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org