You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "2010YOUY01 (via GitHub)" <gi...@apache.org> on 2024/12/01 11:24:05 UTC

[I] Refactor `TableFunctionImpl` to a separate module [datafusion]

2010YOUY01 opened a new issue, #13613:
URL: https://github.com/apache/datafusion/issues/13613

   ### Is your feature request related to a problem or challenge?
   
   Background: https://github.com/apache/datafusion/pull/13540#discussion_r1857679120
   After https://github.com/apache/datafusion/pull/13540 is merged, there is a refactor can be done:
   - Move `TableFunctionImpl` to a separate module
   - Add `name()` method under the trait to keep it consistent with other functions (Like user-defined aggregate function)
   
   ### Describe the solution you'd like
   
   _No response_
   
   ### Describe alternatives you've considered
   
   _No response_
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [I] Refactor `TableFunctionImpl` to a separate module [datafusion]

Posted by "jonathanc-n (via GitHub)" <gi...@apache.org>.
jonathanc-n commented on issue #13613:
URL: https://github.com/apache/datafusion/issues/13613#issuecomment-2510240575

   take


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [I] Refactor `TableFunctionImpl` to a separate module [datafusion]

Posted by "linhr (via GitHub)" <gi...@apache.org>.
linhr commented on issue #13613:
URL: https://github.com/apache/datafusion/issues/13613#issuecomment-2547834504

   It would be valuable if `as_any()` can be part of the `TableFunctionImpl` trait, so that the table function can be cast to the concrete type via `downcast_ref()`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org