You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2016/03/03 17:39:46 UTC
Re: Review Request 39939: Make docker_socket option support different
protocols.
> On Feb. 22, 2016, 4:41 a.m., Klaus Ma wrote:
> > src/slave/flags.cpp, line 437
> > <https://reviews.apache.org/r/39939/diff/1/?file=1115726#file1115726line437>
> >
> > I think we need to handle feature interaction with `docker_mesos_image`. Currently, we mount unix socket into container; but it'll failed when using TCP socket.
Hi, @klaus1982 Sorry to forgot update this. Do you mean we need add a check here?
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39939/#review120096
-----------------------------------------------------------
On Feb. 22, 2016, 3:35 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39939/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2016, 3:35 a.m.)
>
>
> Review request for mesos, Klaus Ma and Timothy Chen.
>
>
> Bugs: MESOS-3821
> https://issues.apache.org/jira/browse/MESOS-3821
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Make docker_socket option support different protocols.
>
>
> Diffs
> -----
>
> docs/configuration.md 195814cf918e018d8287113299163415b94ab09f
> src/docker/docker.hpp 527b3e48edf7e84095a8d9ff4fd1a848c2d529f0
> src/docker/docker.cpp 4ebca660834492f99815a17e04cef6116654dedb
> src/slave/flags.cpp ed9b0b8313f5a5e53f3715af5300d9fcaa936df8
>
> Diff: https://reviews.apache.org/r/39939/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> haosdent huang
>
>