You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by jinmingjian <gi...@git.apache.org> on 2017/02/21 07:26:02 UTC
[GitHub] flink pull request #3373: [FLINK-5692] [config] Add an Option to Deactivate ...
GitHub user jinmingjian opened a pull request:
https://github.com/apache/flink/pull/3373
[FLINK-5692] [config] Add an Option to Deactivate Kryo Fallback for Serializers
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful description of your changes.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the JIRA id)
- [x] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jinmingjian/flink master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3373.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3373
----
commit 1ff46e53efa2094ac6881b1ca014bf7752277ff2
Author: Jin Mingjian <ji...@gmail.com>
Date: 2017-02-21T03:57:21Z
[FLINK-5692] [config] Add an Option to Deactivate Kryo Fallback for Serializers
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3373: [FLINK-5692] [config] Add an Option to Deactivate ...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/3373#discussion_r102753321
--- Diff: flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java ---
@@ -109,6 +109,8 @@
private boolean forceKryo = false;
+ private boolean disableGenericTypes = false;//ISSUE FLINK-5692
--- End diff --
We usually do not add the issues as comments to the code. The git history stores that (commits have the issue number).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3373: [FLINK-5692] [config] Add an Option to Deactivate Kryo Fa...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3373
If you can remove the comment, that would be great. Otherwise we can merge this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3373: [FLINK-5692] [config] Add an Option to Deactivate ...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/3373#discussion_r102429969
--- Diff: flink-core/src/test/java/org/apache/flink/api/common/ExecutionConfigTest.java ---
@@ -64,4 +68,15 @@ public void testConfigurationOfParallelism() {
assertEquals(parallelism, config.getParallelism());
}
+ @Test(expected = UnsupportedOperationException.class)
--- End diff --
I think this test would also pass of line 75 already throws the exception.
I personally discourage the `@Test(expected = )` pattern completely, as you have no check which statement actually throws the exception.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3373: [FLINK-5692] [config] Add an Option to Deactivate Kryo Fa...
Posted by jinmingjian <gi...@git.apache.org>.
Github user jinmingjian commented on the issue:
https://github.com/apache/flink/pull/3373
@StephanEwen Just my coding habit. Correction done.
And very appreciated for your review. I am open for more contribution! :tada:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3373: [FLINK-5692] [config] Add an Option to Deactivate Kryo Fa...
Posted by jinmingjian <gi...@git.apache.org>.
Github user jinmingjian commented on the issue:
https://github.com/apache/flink/pull/3373
revision done. _"disableGenericTypes"_ makes good sense from the view of docs (although "generic types" tends to be overused).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3373: [FLINK-5692] [config] Add an Option to Deactivate Kryo Fa...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3373
The change looks good, merging this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3373: [FLINK-5692] [config] Add an Option to Deactivate ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3373
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---