You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org> on 2023/11/13 17:24:08 UTC
[Impala-ASF-CR] IMPALA-12556: Fix flaky test test two statestored with force active
Wenzhe Zhou has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20699
Change subject: IMPALA-12556: Fix flaky test test_two_statestored_with_force_active
......................................................................
IMPALA-12556: Fix flaky test test_two_statestored_with_force_active
Test test_two_statestored_with_force_active failed occasionally by
cause of both statestore instances assigned with active roles.
This patch fixes the issue to handle the case that both statestore
instances are restarted with flag "statestore_force_active" in the
same way as both statestore instances are restarted without flag
"statestore_force_active".
Testing:
- Repeatedly ran test_two_statestored_with_force_active on Jenkins for
hundreds of times without failure.
- Repeatedly ran test_two_statestored_with_force_active on local
machine for thousand times without failure.
- Repeatedly ran all tests in test_statestored_ha.py for over 12 hours
on Jenkins without failure.
- Passed core tests.
Change-Id: I3e6f85233ff6fa747a6aa5ef8d093627885d20b2
---
M be/src/statestore/statestore-subscriber.cc
M be/src/statestore/statestore.cc
2 files changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/20699/2
--
To view, visit http://gerrit.cloudera.org:8080/20699
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3e6f85233ff6fa747a6aa5ef8d093627885d20b2
Gerrit-Change-Number: 20699
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-12556: Fix flaky test test two statestored with force active
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has removed a vote on this change.
Change subject: IMPALA-12556: Fix flaky test test_two_statestored_with_force_active
......................................................................
Removed Verified-1 by Impala Public Jenkins <im...@cloudera.com>
--
To view, visit http://gerrit.cloudera.org:8080/20699
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I3e6f85233ff6fa747a6aa5ef8d093627885d20b2
Gerrit-Change-Number: 20699
Gerrit-PatchSet: 3
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-12556: Fix flaky test test two statestored with force active
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20699 )
Change subject: IMPALA-12556: Fix flaky test test_two_statestored_with_force_active
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/20699
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e6f85233ff6fa747a6aa5ef8d093627885d20b2
Gerrit-Change-Number: 20699
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 13 Nov 2023 21:17:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12556: Fix flaky test test two statestored with force active
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20699 )
Change subject: IMPALA-12556: Fix flaky test test_two_statestored_with_force_active
......................................................................
IMPALA-12556: Fix flaky test test_two_statestored_with_force_active
Test test_two_statestored_with_force_active failed occasionally by
cause of both statestore instances assigned with active roles.
This patch fixes the issue to handle the case that both statestore
instances are restarted with flag "statestore_force_active" in the
same way as both statestore instances are restarted without flag
"statestore_force_active".
Testing:
- Repeatedly ran test_two_statestored_with_force_active on Jenkins for
hundreds of times without failure.
- Repeatedly ran test_two_statestored_with_force_active on local
machine for thousand times without failure.
- Repeatedly ran all tests in test_statestored_ha.py for over 12 hours
on Jenkins without failure.
- Passed core tests.
Change-Id: I3e6f85233ff6fa747a6aa5ef8d093627885d20b2
Reviewed-on: http://gerrit.cloudera.org:8080/20699
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Wenzhe Zhou <wz...@cloudera.com>
---
M be/src/statestore/statestore-subscriber.cc
M be/src/statestore/statestore.cc
2 files changed, 4 insertions(+), 2 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved
Wenzhe Zhou: Verified
--
To view, visit http://gerrit.cloudera.org:8080/20699
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3e6f85233ff6fa747a6aa5ef8d093627885d20b2
Gerrit-Change-Number: 20699
Gerrit-PatchSet: 4
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-12556: Fix flaky test test two statestored with force active
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20699 )
Change subject: IMPALA-12556: Fix flaky test test_two_statestored_with_force_active
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/14430/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/20699
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e6f85233ff6fa747a6aa5ef8d093627885d20b2
Gerrit-Change-Number: 20699
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 13 Nov 2023 17:44:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12556: Fix flaky test test two statestored with force active
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20699 )
Change subject: IMPALA-12556: Fix flaky test test_two_statestored_with_force_active
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/20699
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e6f85233ff6fa747a6aa5ef8d093627885d20b2
Gerrit-Change-Number: 20699
Gerrit-PatchSet: 3
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 13 Nov 2023 21:17:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12556: Fix flaky test test two statestored with force active
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20699 )
Change subject: IMPALA-12556: Fix flaky test test_two_statestored_with_force_active
......................................................................
Patch Set 3: Verified+1
Hit irrelevant IMPALA-12187.
--
To view, visit http://gerrit.cloudera.org:8080/20699
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e6f85233ff6fa747a6aa5ef8d093627885d20b2
Gerrit-Change-Number: 20699
Gerrit-PatchSet: 3
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Nov 2023 01:45:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12556: Fix flaky test test two statestored with force active
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20699 )
Change subject: IMPALA-12556: Fix flaky test test_two_statestored_with_force_active
......................................................................
Patch Set 3: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9921/
--
To view, visit http://gerrit.cloudera.org:8080/20699
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e6f85233ff6fa747a6aa5ef8d093627885d20b2
Gerrit-Change-Number: 20699
Gerrit-PatchSet: 3
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Nov 2023 01:43:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12556: Fix flaky test test two statestored with force active
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20699 )
Change subject: IMPALA-12556: Fix flaky test test_two_statestored_with_force_active
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9921/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/20699
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e6f85233ff6fa747a6aa5ef8d093627885d20b2
Gerrit-Change-Number: 20699
Gerrit-PatchSet: 3
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 13 Nov 2023 21:17:43 +0000
Gerrit-HasComments: No