You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "xingtanzjr (via GitHub)" <gi...@apache.org> on 2023/07/20 10:20:09 UTC

[GitHub] [iotdb] xingtanzjr opened a new pull request, #10628: Fix the NPE issue when taking snapshot in WAL combined with Aligned Binary

xingtanzjr opened a new pull request, #10628:
URL: https://github.com/apache/iotdb/pull/10628

   ## Description
   In some scenario, the Binary in AlignedTVList will be null if this field is empty in current row. We need to handle this scenario to get rid of NPE in WAL snapshot taking stage. 
   
   See a similar issue here: https://github.com/apache/iotdb/pull/9884 
   
   **Current fix**: we use an empty Binary as a placeholder here. It won't lead to data error because whether this field is null or not is decided by the bitMap rather than the object's value here.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [iotdb] HTHou merged pull request #10628: [To rel/1.2] Fix the NPE issue when taking snapshot in WAL combined with Aligned Binary

Posted by "HTHou (via GitHub)" <gi...@apache.org>.
HTHou merged PR #10628:
URL: https://github.com/apache/iotdb/pull/10628


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [iotdb] coveralls commented on pull request #10628: [To rel/1.2] Fix the NPE issue when taking snapshot in WAL combined with Aligned Binary

Posted by "coveralls (via GitHub)" <gi...@apache.org>.
coveralls commented on PR #10628:
URL: https://github.com/apache/iotdb/pull/10628#issuecomment-1643747223

   
   [![Coverage Status](https://coveralls.io/builds/61468422/badge)](https://coveralls.io/builds/61468422)
   
   coverage: 47.783% (-0.003%) from 47.786% when pulling **57fb6d7ad95783ab6e65673d0e3ab216ecd7fdde on fix_wal_npe_binary_rel12** into **2c0ba0db88f27ddb5acb837133046a7bc86151c4 on rel/1.2**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org