You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kevin Klues <kl...@gmail.com> on 2016/12/06 19:46:04 UTC
Review Request 54441: Added function to unblock IOSwitchboard when
waiting for connection.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54441/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Repository: mesos
Description
-------
Added function to unblock IOSwitchboard when waiting for connection.
Diffs
-----
src/slave/containerizer/mesos/io/switchboard.hpp 839665a22aca9b1c1c1cf4992406bc924ee2b065
src/slave/containerizer/mesos/io/switchboard.cpp 19f2b625f2aa4b790fbe80b8dfad44b219f2c24e
Diff: https://reviews.apache.org/r/54441/diff/
Testing
-------
make check
Thanks,
Kevin Klues
Re: Review Request 54441: Added function to unblock IOSwitchboard when
waiting for connection.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54441/#review158215
-----------------------------------------------------------
Fix it, then Ship it!
src/slave/containerizer/mesos/io/switchboard.cpp (lines 892 - 894)
<https://reviews.apache.org/r/54441/#comment229006>
I would just call 'set' here. No need for the if check here.
- Jie Yu
On Dec. 6, 2016, 7:58 p.m., Kevin Klues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54441/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2016, 7:58 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-6664
> https://issues.apache.org/jira/browse/MESOS-6664
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added function to unblock IOSwitchboard when waiting for connection.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/io/switchboard.hpp 839665a22aca9b1c1c1cf4992406bc924ee2b065
> src/slave/containerizer/mesos/io/switchboard.cpp 19f2b625f2aa4b790fbe80b8dfad44b219f2c24e
>
> Diff: https://reviews.apache.org/r/54441/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Kevin Klues
>
>
Re: Review Request 54441: Added function to unblock IOSwitchboard when
waiting for connection.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54441/
-----------------------------------------------------------
(Updated Dec. 6, 2016, 11:01 p.m.)
Review request for mesos and Jie Yu.
Changes
-------
Updated based on Jie's comments.
Bugs: MESOS-6664
https://issues.apache.org/jira/browse/MESOS-6664
Repository: mesos
Description
-------
Added function to unblock IOSwitchboard when waiting for connection.
Diffs (updated)
-----
src/slave/containerizer/mesos/io/switchboard.hpp 839665a22aca9b1c1c1cf4992406bc924ee2b065
src/slave/containerizer/mesos/io/switchboard.cpp 0254bd2f37cedd90f37d7b3e38a9b47e3d0fc3a6
Diff: https://reviews.apache.org/r/54441/diff/
Testing
-------
make check
Thanks,
Kevin Klues
Re: Review Request 54441: Added function to unblock IOSwitchboard when
waiting for connection.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54441/
-----------------------------------------------------------
(Updated Dec. 6, 2016, 7:58 p.m.)
Review request for mesos and Jie Yu.
Bugs: MESOS-6664
https://issues.apache.org/jira/browse/MESOS-6664
Repository: mesos
Description
-------
Added function to unblock IOSwitchboard when waiting for connection.
Diffs
-----
src/slave/containerizer/mesos/io/switchboard.hpp 839665a22aca9b1c1c1cf4992406bc924ee2b065
src/slave/containerizer/mesos/io/switchboard.cpp 19f2b625f2aa4b790fbe80b8dfad44b219f2c24e
Diff: https://reviews.apache.org/r/54441/diff/
Testing
-------
make check
Thanks,
Kevin Klues