You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gora.apache.org by Alparslan Avcı <al...@gmail.com> on 2014/05/02 13:08:24 UTC

_ALL_FIELDS array in Persistent classes

Hi folks,

In auto-generated persistent classes, we create an array field called
_ALL_FIELDS as you know. But this array also contains __g__dirty field,
which is not a stored field at all. Maybe we should remove __g__dirty field
from the array, since the array is used for getting all fields in the
stored table. We can also remove it from Field enum, so the users do not
know about the __g__dirty field.

Wdyt?

Thanks.


-- 
Alparslan Avcı

Re: _ALL_FIELDS array in Persistent classes

Posted by Renato Marroquín Mogrovejo <re...@gmail.com>.

Hi Alparslan,

This totally makes sense, and specially because __g__dirty is an internal
field, and users shouldn't be given tools to bad things ;)
If you put a patch for this, I will happily review it.


Renato M.


2014-05-02 13:08 GMT+02:00 Alparslan Avcı <al...@gmail.com>:

> Hi folks,
>
> In auto-generated persistent classes, we create an array field called
> _ALL_FIELDS as you know. But this array also contains __g__dirty field,
> which is not a stored field at all. Maybe we should remove __g__dirty field
> from the array, since the array is used for getting all fields in the
> stored table. We can also remove it from Field enum, so the users do not
> know about the __g__dirty field.
>
> Wdyt?
>
> Thanks.
>
>
> --
> Alparslan Avcı
>

Re: _ALL_FIELDS array in Persistent classes

Posted by Talat Uyarer <ta...@uyarer.com>.

Hi Folks,
You should remove __g__ dirty field. IMHO, we shouldn't send out our
specific fields.

Talat

2014-05-02 14:08 GMT+03:00 Alparslan Avcı <al...@gmail.com>:
> Hi folks,
>
> In auto-generated persistent classes, we create an array field called
> _ALL_FIELDS as you know. But this array also contains __g__dirty field,
> which is not a stored field at all. Maybe we should remove __g__dirty field
> from the array, since the array is used for getting all fields in the
> stored table. We can also remove it from Field enum, so the users do not
> know about the __g__dirty field.
>
> Wdyt?
>
> Thanks.
>
>
> --
> Alparslan Avcı



-- 
Talat UYARER
Websitesi: http://talat.uyarer.com
Twitter: http://twitter.com/talatuyarer
Linkedin: http://tr.linkedin.com/pub/talat-uyarer/10/142/304