You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/07/19 16:29:10 UTC
[GitHub] [trafficserver] zwoop opened a new pull request #8082: Changes HttpSM to be Proxy Allocated
zwoop opened a new pull request #8082:
URL: https://github.com/apache/trafficserver/pull/8082
A few comments on this:
1. I couldn't get the proxy allocation macros to work inside the HttpSM::allocate. But, this patch looks more like what we do for other allocators, making it explicit where we need to allocate a new HttpSM. If someone feels strongly that HttpSM::allocate has to survive, I can see if there's a way to make it work.
2. Bryan requested that I verify that the allocation of the HttpSM happens on the ET_NET thread even with accept threads, and I did verify that and it does. So the HttpSM gets allocated and released on the same ET_NET thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop merged pull request #8082: Changes HttpSM to be Proxy Allocated
Posted by GitBox <gi...@apache.org>.
zwoop merged pull request #8082:
URL: https://github.com/apache/trafficserver/pull/8082
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on pull request #8082: Changes HttpSM to be Proxy Allocated
Posted by GitBox <gi...@apache.org>.
bryancall commented on pull request #8082:
URL: https://github.com/apache/trafficserver/pull/8082#issuecomment-882941749
@zwoop can you post the performance numbers of having a proxy allocator for the HttpSM vs not?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #8082: Changes HttpSM to be Proxy Allocated
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #8082:
URL: https://github.com/apache/trafficserver/pull/8082#issuecomment-883641867
The performance increase is not tremendous, about 5%. It's possible it make more of a difference on other hardware platforms, where the costs of the atomic operations on the class allocator causes more contention.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on pull request #8082: Changes HttpSM to be Proxy Allocated
Posted by GitBox <gi...@apache.org>.
bryancall commented on pull request #8082:
URL: https://github.com/apache/trafficserver/pull/8082#issuecomment-882941749
@zwoop can you post the performance numbers of having a proxy allocator for the HttpSM vs not?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on pull request #8082: Changes HttpSM to be Proxy Allocated
Posted by GitBox <gi...@apache.org>.
bryancall commented on pull request #8082:
URL: https://github.com/apache/trafficserver/pull/8082#issuecomment-882941749
@zwoop can you post the performance numbers of having a proxy allocator for the HttpSM vs not?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #8082: Changes HttpSM to be Proxy Allocated
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #8082:
URL: https://github.com/apache/trafficserver/pull/8082#issuecomment-883507812
I've tried this on master, 9.1.x and 9.0.x branches, and on the 9.0.x branch, it will assert always. 9.1.x or master does not have this problem, I think something changed around either the class allocators or the constructor / destructors for the HttpSM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #8082: Changes HttpSM to be Proxy Allocated
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #8082:
URL: https://github.com/apache/trafficserver/pull/8082#issuecomment-893595309
Cherry-picked to v9.1.x branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org