You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "RobertIndie (via GitHub)" <gi...@apache.org> on 2023/06/25 12:37:32 UTC
[GitHub] [pulsar-client-go] RobertIndie commented on a diff in pull request #1035: [Refactor] refactor duplicated code lines and fix typo errors
RobertIndie commented on code in PR #1035:
URL: https://github.com/apache/pulsar-client-go/pull/1035#discussion_r1241158304
##########
integration-tests/pb/hello.pb.go:
##########
@@ -25,10 +25,11 @@
package __
import (
- protoreflect "google.golang.org/protobuf/reflect/protoreflect"
- protoimpl "google.golang.org/protobuf/runtime/protoimpl"
reflect "reflect"
sync "sync"
+
+ protoreflect "google.golang.org/protobuf/reflect/protoreflect"
+ protoimpl "google.golang.org/protobuf/runtime/protoimpl"
)
Review Comment:
Why do you edit `*.pb.go` files? From the comment line 19:
```
// Code generated by protoc-gen-go. DO NOT EDIT.
// versions:
// protoc-gen-go v1.30.0
// protoc v3.21.12
// source: hello.proto
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org