You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Mathieu Lirzin <mt...@apache.org> on 2019/03/22 16:10:35 UTC

When do we need a JIRA? (was: svn commit: r1855798 - /ofbiz/ofbiz-framework/trunk/build.gradle)

Hello,

In the same spirit, I want to know if it is OK to improve or add some
Javadoc without opening a ticket on JIRA?

Thanks.

Mathieu Lirzin <mt...@apache.org> writes:

> Hello Michael,
>
> Michael Brohl <mi...@ecomify.de> writes:
>
>> don't we have Jira's for all these changes?
>>
>> If yes, please provide the issue number within the commit message so
>> that we have them in the monthly blog post/dev details.
>>
>> If no, we should have them, at least in the future.
>
> Sorry if the process I followed was not the right one.
>
> I must confess that the policy regarding how refactoring (done by
> committers) must be handled in term of JIRA creation, is not clear to
> me.  The block “When to create a Jira issue” on OFBiz wiki [1] is not
> helping much in that regard.  Maybe there is an implicit consensus in
> that regard that I am not aware of?
>
> My reasoning for not creating a JIRA was that those commits are pure
> refactoring meaning they are implementation details that don't change
> the observable behavior of the build and they are not part of a global
> plan.  Basically those cleanups happened by looking around while working
> on OFBIZ-10866 [2] but are unrelated to the endeavour of that task.
>
> What would you recommend in that scenario?
>
>> If these changes affect the documentation, the README.md should also
>> be edited to reflect them and stay in sync with the code.
>
> Sure I agree that's an important guideline to follow.
>
> Thanks.
>
> [1] https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Contributors+Best+Practices
> [2] https://issues.apache.org/jira/browse/OFBIZ-10866

-- 
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37