You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by derrickdoo <gi...@git.apache.org> on 2017/05/30 23:10:18 UTC
[GitHub] kafka-site pull request #58: [PLEASE DO NOT MERGE] Further break apart Strea...
GitHub user derrickdoo opened a pull request:
https://github.com/apache/kafka-site/pull/58
[PLEASE DO NOT MERGE] Further break apart Streams docs
This is just to illustrate necessary changes for changing the structure of Streams documentation.
Please don't merge yet.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/derrickdoo/kafka-site streams-routing-and-styles
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka-site/pull/58.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #58
----
commit 432ece78379fa09b749a01658b9809c095f56704
Author: Derrick Or <de...@gmail.com>
Date: 2017-05-30T23:03:27Z
structure and style adjustments for streams docs
remove debugger
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] kafka-site pull request #58: Break apart Streams docs
Posted by derrickdoo <gi...@git.apache.org>.
Github user derrickdoo commented on a diff in the pull request:
https://github.com/apache/kafka-site/pull/58#discussion_r125121166
--- Diff: includes/_footer.htm ---
@@ -32,7 +32,8 @@
'streams',
'quickstart',
'toc',
- 'upgrade'
+ 'upgrade',
+ 'content'
--- End diff --
I did this on purpose so we could have a generic name for containers that we know aren't going to rendered alongside themselves. It just makes it easier for other to copy and paste existing pages and build off of them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] kafka-site pull request #58: Break apart Streams docs
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/kafka-site/pull/58
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] kafka-site pull request #58: Break apart Streams docs
Posted by guozhangwang <gi...@git.apache.org>.
Github user guozhangwang commented on a diff in the pull request:
https://github.com/apache/kafka-site/pull/58#discussion_r125140531
--- Diff: includes/_footer.htm ---
@@ -32,7 +32,8 @@
'streams',
'quickstart',
'toc',
- 'upgrade'
+ 'upgrade',
+ 'content'
--- End diff --
Got it, makes sense.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] kafka-site issue #58: Break apart Streams docs
Posted by guozhangwang <gi...@git.apache.org>.
Github user guozhangwang commented on the issue:
https://github.com/apache/kafka-site/pull/58
Merged to `asf-site`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] kafka-site pull request #58: Break apart Streams docs
Posted by guozhangwang <gi...@git.apache.org>.
Github user guozhangwang commented on a diff in the pull request:
https://github.com/apache/kafka-site/pull/58#discussion_r125117603
--- Diff: includes/_footer.htm ---
@@ -32,7 +32,8 @@
'streams',
'quickstart',
'toc',
- 'upgrade'
+ 'upgrade',
+ 'content'
--- End diff --
I found this name a bit misleading.. could we rename it to `streams-content` or `streams-subpages`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---