You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2018/04/02 18:42:45 UTC
[kudu-CR] Followup to bae6170c77 to fix build on macos
Hello Adar Dembo, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/9888
to review the following change.
Change subject: Followup to bae6170c77 to fix build on macos
......................................................................
Followup to bae6170c77 to fix build on macos
RLIM_INFINITY is kint64max on MacOS and kuint64max on Linux.
Change-Id: I13780d86d4a286710c1bcf8a5f4266fb7fe162c7
---
M src/kudu/util/env_posix.cc
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/9888/1
--
To view, visit http://gerrit.cloudera.org:8080/9888
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I13780d86d4a286710c1bcf8a5f4266fb7fe162c7
Gerrit-Change-Number: 9888
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Followup to bae6170c77 to fix build on macos
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9888 )
Change subject: Followup to bae6170c77 to fix build on macos
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9888
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I13780d86d4a286710c1bcf8a5f4266fb7fe162c7
Gerrit-Change-Number: 9888
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 02 Apr 2018 18:44:40 +0000
Gerrit-HasComments: No
[kudu-CR] Followup to bae6170c77 to fix build on macos
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9888
to look at the new patch set (#4).
Change subject: Followup to bae6170c77 to fix build on macos
......................................................................
Followup to bae6170c77 to fix build on macos
RLIM_INFINITY is kint64max on MacOS and kuint64max on Linux.
Change-Id: I13780d86d4a286710c1bcf8a5f4266fb7fe162c7
---
M src/kudu/util/env.h
M src/kudu/util/env_posix.cc
2 files changed, 3 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/9888/4
--
To view, visit http://gerrit.cloudera.org:8080/9888
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I13780d86d4a286710c1bcf8a5f4266fb7fe162c7
Gerrit-Change-Number: 9888
Gerrit-PatchSet: 4
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Followup to bae6170c77 to fix build on macos
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9888 )
Change subject: Followup to bae6170c77 to fix build on macos
......................................................................
Patch Set 4: Verified+1
Failure appears to be unrelated flake.
--
To view, visit http://gerrit.cloudera.org:8080/9888
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I13780d86d4a286710c1bcf8a5f4266fb7fe162c7
Gerrit-Change-Number: 9888
Gerrit-PatchSet: 4
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 02 Apr 2018 22:06:59 +0000
Gerrit-HasComments: No
[kudu-CR] Followup to bae6170c77 to fix build on macos
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9888
to look at the new patch set (#2).
Change subject: Followup to bae6170c77 to fix build on macos
......................................................................
Followup to bae6170c77 to fix build on macos
RLIM_INFINITY is kint64max on MacOS and kuint64max on Linux.
Change-Id: I13780d86d4a286710c1bcf8a5f4266fb7fe162c7
---
M src/kudu/util/env.h
M src/kudu/util/env_posix.cc
2 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/9888/2
--
To view, visit http://gerrit.cloudera.org:8080/9888
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I13780d86d4a286710c1bcf8a5f4266fb7fe162c7
Gerrit-Change-Number: 9888
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Followup to bae6170c77 to fix build on macos
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9888 )
Change subject: Followup to bae6170c77 to fix build on macos
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9888/2/src/kudu/util/env.h
File src/kudu/util/env.h:
http://gerrit.cloudera.org:8080/#/c/9888/2/src/kudu/util/env.h@322
PS2, Line 322: If there is
: // no limit, returns RLIM_INFINITY which is guaranteed to be positive.
> Hmm, but we don't want to leak RLIM_INFINITY outside env; it's an implement
Alternatively, maybe we can just remove this sentence? AFAICT callers can completely ignore that there is such thing as no limit or RLIM_INFINITY. They can just treat the return value as the true limit.
--
To view, visit http://gerrit.cloudera.org:8080/9888
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I13780d86d4a286710c1bcf8a5f4266fb7fe162c7
Gerrit-Change-Number: 9888
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 02 Apr 2018 18:58:49 +0000
Gerrit-HasComments: Yes
[kudu-CR] Followup to bae6170c77 to fix build on macos
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9888 )
Change subject: Followup to bae6170c77 to fix build on macos
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9888/2/src/kudu/util/env.h
File src/kudu/util/env.h:
http://gerrit.cloudera.org:8080/#/c/9888/2/src/kudu/util/env.h@322
PS2, Line 322: If there is
: // no limit, returns RLIM_INFINITY which is guaranteed to be positive.
Hmm, but we don't want to leak RLIM_INFINITY outside env; it's an implementation detail as far as callers are concerned.
Perhaps "If there is no limit, returns a very large number (such as kint64max or kuint64max, depending on the platform)?"
--
To view, visit http://gerrit.cloudera.org:8080/9888
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I13780d86d4a286710c1bcf8a5f4266fb7fe162c7
Gerrit-Change-Number: 9888
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 02 Apr 2018 18:48:16 +0000
Gerrit-HasComments: Yes
[kudu-CR] Followup to bae6170c77 to fix build on macos
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9888 )
Change subject: Followup to bae6170c77 to fix build on macos
......................................................................
Followup to bae6170c77 to fix build on macos
RLIM_INFINITY is kint64max on MacOS and kuint64max on Linux.
Change-Id: I13780d86d4a286710c1bcf8a5f4266fb7fe162c7
Reviewed-on: http://gerrit.cloudera.org:8080/9888
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Dan Burkert <da...@apache.org>
---
M src/kudu/util/env.h
M src/kudu/util/env_posix.cc
2 files changed, 3 insertions(+), 5 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Dan Burkert: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9888
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I13780d86d4a286710c1bcf8a5f4266fb7fe162c7
Gerrit-Change-Number: 9888
Gerrit-PatchSet: 5
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Followup to bae6170c77 to fix build on macos
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9888 )
Change subject: Followup to bae6170c77 to fix build on macos
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9888
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I13780d86d4a286710c1bcf8a5f4266fb7fe162c7
Gerrit-Change-Number: 9888
Gerrit-PatchSet: 4
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 02 Apr 2018 21:08:55 +0000
Gerrit-HasComments: No
[kudu-CR] Followup to bae6170c77 to fix build on macos
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9888 )
Change subject: Followup to bae6170c77 to fix build on macos
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9888
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I13780d86d4a286710c1bcf8a5f4266fb7fe162c7
Gerrit-Change-Number: 9888
Gerrit-PatchSet: 3
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 02 Apr 2018 20:49:46 +0000
Gerrit-HasComments: No
[kudu-CR] Followup to bae6170c77 to fix build on macos
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/9888 )
Change subject: Followup to bae6170c77 to fix build on macos
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/9888
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I13780d86d4a286710c1bcf8a5f4266fb7fe162c7
Gerrit-Change-Number: 9888
Gerrit-PatchSet: 4
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Followup to bae6170c77 to fix build on macos
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9888 )
Change subject: Followup to bae6170c77 to fix build on macos
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9888/2/src/kudu/util/env.h
File src/kudu/util/env.h:
http://gerrit.cloudera.org:8080/#/c/9888/2/src/kudu/util/env.h@322
PS2, Line 322: If there is
: // no limit, returns RLIM_INFINITY which is guaranteed to be positive.
> Alternatively, maybe we can just remove this sentence? AFAICT callers can
Yeah that's an option too; I guess I was concerned that callers may know that rlimits on UNIX have a concept of "no limit" and would go hunting for it if it wasn't explicitly talked about. But it's probably not a real issue.
--
To view, visit http://gerrit.cloudera.org:8080/9888
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I13780d86d4a286710c1bcf8a5f4266fb7fe162c7
Gerrit-Change-Number: 9888
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 02 Apr 2018 19:23:42 +0000
Gerrit-HasComments: Yes
[kudu-CR] Followup to bae6170c77 to fix build on macos
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9888
to look at the new patch set (#3).
Change subject: Followup to bae6170c77 to fix build on macos
......................................................................
Followup to bae6170c77 to fix build on macos
RLIM_INFINITY is kint64max on MacOS and kuint64max on Linux.
Change-Id: I13780d86d4a286710c1bcf8a5f4266fb7fe162c7
---
M src/kudu/util/env.h
M src/kudu/util/env_posix.cc
2 files changed, 3 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/9888/3
--
To view, visit http://gerrit.cloudera.org:8080/9888
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I13780d86d4a286710c1bcf8a5f4266fb7fe162c7
Gerrit-Change-Number: 9888
Gerrit-PatchSet: 3
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>