You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/07/22 10:09:54 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
HyukjinKwon opened a new pull request #29188:
URL: https://github.com/apache/spark/pull/29188
### What changes were proposed in this pull request?
This PR proposes to redesign the PySpark documentation.
I made a demo site to make it easier to review: https://hyukjin-spark.readthedocs.io/en/stable/reference/index.html.
Here is the initial draft for the final PySpark docs shape: https://hyukjin-spark.readthedocs.io/en/latest/index.html.
In more details, this PR proposes:
1. Use [pydata_sphinx_theme](https://github.com/pandas-dev/pydata-sphinx-theme) theme - [pandas](https://pandas.pydata.org/docs/) and [Koalas](https://koalas.readthedocs.io/en/latest/) use the same themes. The CSS overwrite is ported from Koalas. The colours in the CSS were actually chosen by designers to use in Spark.
2. Use the Sphinx option to separate `source` and `build` directories as the documentation pages will likely grow.
3. Port current API documentation into the new style. It mimics Koalas and pandas to use the theme most effectively.
### Why are the changes needed?
Often I hear the complaints, from the users, that current PySpark documentation is pretty messy to read - https://spark.apache.org/docs/latest/api/python/index.html compared other projects such as [pandas](https://pandas.pydata.org/docs/) and [Koalas](https://koalas.readthedocs.io/en/latest/).
It would be nicer if we can make it more organised instead of just listing all classes, methods and attributes to make it easier to navigate.
Also, the documentation has been there from almost the very first version of PySpark. Maybe it's time to update it.
### Does this PR introduce _any_ user-facing change?
Yes, PySpark API documentation will be redesigned.
### How was this patch tested?
Manually tested, and the demo site was made to show.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662938220
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662548651
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662427304
**[Test build #126334 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126334/testReport)** for PR 29188 at commit [`7567003`](https://github.com/apache/spark/commit/75670034671ea7cff562cb1db4079cf0924933a7).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #29188:
URL: https://github.com/apache/spark/pull/29188#discussion_r458688468
##########
File path: python/docs/source/_templates/class_with_docs.rst
##########
@@ -0,0 +1,79 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+.. http://www.apache.org/licenses/LICENSE-2.0
+
+.. Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+
+{{ objname }}
+{{ underline }}
+
+.. currentmodule:: {{ module }}
+
+.. autoclass:: {{ objname }}
+
+ {% if '__init__' in methods %}
+ {% set caught_result = methods.remove('__init__') %}
+ {% endif %}
+
+ {% block methods_summary %}
+ {% if methods %}
+
+ .. rubric:: Methods
+
+ .. autosummary::
+ {% for item in methods %}
+ ~{{ name }}.{{ item }}
+ {%- endfor %}
+
+ {% endif %}
+ {% endblock %}
+
+ {% block attributes_summary %}
+ {% if attributes %}
+
+ .. rubric:: Attributes
+
+ .. autosummary::
+ {% for item in attributes %}
+ ~{{ name }}.{{ item }}
+ {%- endfor %}
+
+ {% endif %}
+ {% endblock %}
+
+ {% block methods_documentation %}
+ {% if methods %}
+
+ .. rubric:: Methods Documentation
+
+ {% for item in methods %}
+ .. automethod:: {{ item }}
+ {%- endfor %}
+
+ {% endif %}
+ {% endblock %}
+
+ {% block attributes_documentation %}
+ {% if attributes %}
+
+ .. rubric:: Attributes Documentation
+
+ {% for item in attributes %}
+ .. autoattribute:: {{ item }}
+ {%- endfor %}
+
+ {% endif %}
+ {% endblock %}
+
Review comment:
This is needed to let `autosummary` plugin document the methods in a class. For example, when we use this template, it describes methods documentation on the bottom. See [pyspark.ml.Transformer](https://hyukjin-spark.readthedocs.io/en/stable/reference/api/pyspark.ml.Transformer.html#pyspark.ml.Transformer) as an example.
Without this template, it only lists the methods and attributes without showing the documentation in details. See [pyspark.sql.DataFrameNaFunctions](https://hyukjin-spark.readthedocs.io/en/stable/reference/api/pyspark.sql.DataFrameNaFunctions.html#pyspark.sql.DataFrameNaFunctions) as an example.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #29188:
URL: https://github.com/apache/spark/pull/29188#discussion_r459243054
##########
File path: python/pyspark/sql/functions.py
##########
@@ -1196,6 +1196,8 @@ def to_date(col, format=None):
By default, it follows casting rules to :class:`pyspark.sql.types.DateType` if the format
is omitted. Equivalent to ``col.cast("date")``.
+ .. _datetime pattern: https://spark.apache.org/docs/latest/sql-ref-datetime-pattern.html
Review comment:
This is needed because we're now creating each page for each API. For example, see https://hyukjin-spark.readthedocs.io/en/stable/reference/api/pyspark.sql.functions.to_date.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662843769
**[Test build #126390 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126390/testReport)** for PR 29188 at commit [`8a6d316`](https://github.com/apache/spark/commit/8a6d31645118cd96cf1524d06e076bac3d7e14fe).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662885181
**[Test build #126404 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126404/testReport)** for PR 29188 at commit [`aa200ec`](https://github.com/apache/spark/commit/aa200ec176ad217429a4a91d402d72d89530cf07).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662367871
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662392996
**[Test build #126330 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126330/testReport)** for PR 29188 at commit [`c448b23`](https://github.com/apache/spark/commit/c448b23f1a711a1220c2197db663be4d11854e0c).
* This patch **fails Python style tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662851359
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126390/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-664332877
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662518810
**[Test build #126336 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126336/testReport)** for PR 29188 at commit [`1c6fe6c`](https://github.com/apache/spark/commit/1c6fe6c04e5680452b9aa27ba296e2471a54e650).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
huaxingao commented on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662720777
Looks really nice! It's more organized this way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662435411
**[Test build #126335 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126335/testReport)** for PR 29188 at commit [`54ffa45`](https://github.com/apache/spark/commit/54ffa45c195e4479d1d9eb7bbcab4d49825560cf).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662766767
The demo website looks nice although I didn't generate manually this PR~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-664331962
**[Test build #126627 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126627/testReport)** for PR 29188 at commit [`d6d0117`](https://github.com/apache/spark/commit/d6d011737aba77e7eca41c1b65d6588764856797).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662882502
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #29188:
URL: https://github.com/apache/spark/pull/29188#discussion_r458686040
##########
File path: .gitignore
##########
@@ -64,6 +64,7 @@ python/lib/pyspark.zip
python/.eggs/
python/deps
python/docs/_site/
+python/docs/source/reference/api/
Review comment:
This is generated by `autosummary` plugin in Sphinx when `autosummary_generate` in `conf.py` is enabled. Each page of API or class under `autosummary` directive, for example, [`DataFrame.alias`](https://hyukjin-spark.readthedocs.io/en/stable/reference/api/pyspark.sql.DataFrame.alias.html#pyspark.sql.DataFrame.alias) will be generated via that plugin as RST files.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-664757150
The demo website looks great!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662843476
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
zero323 commented on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662666798
Looks nice. I miss a bit direct access to docstrings, but I guess that's a reasonable trade-off.
I wonder if there is some non-hacky way to organize functions into logical groups, similarly to what ScalaDoc does.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-663341971
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662843769
**[Test build #126390 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126390/testReport)** for PR 29188 at commit [`8a6d316`](https://github.com/apache/spark/commit/8a6d31645118cd96cf1524d06e076bac3d7e14fe).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662885181
**[Test build #126404 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126404/testReport)** for PR 29188 at commit [`aa200ec`](https://github.com/apache/spark/commit/aa200ec176ad217429a4a91d402d72d89530cf07).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #29188:
URL: https://github.com/apache/spark/pull/29188
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662431440
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662883744
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #29188:
URL: https://github.com/apache/spark/pull/29188#discussion_r458688468
##########
File path: python/docs/source/_templates/class_with_docs.rst
##########
@@ -0,0 +1,79 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+.. http://www.apache.org/licenses/LICENSE-2.0
+
+.. Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+
+{{ objname }}
+{{ underline }}
+
+.. currentmodule:: {{ module }}
+
+.. autoclass:: {{ objname }}
+
+ {% if '__init__' in methods %}
+ {% set caught_result = methods.remove('__init__') %}
+ {% endif %}
+
+ {% block methods_summary %}
+ {% if methods %}
+
+ .. rubric:: Methods
+
+ .. autosummary::
+ {% for item in methods %}
+ ~{{ name }}.{{ item }}
+ {%- endfor %}
+
+ {% endif %}
+ {% endblock %}
+
+ {% block attributes_summary %}
+ {% if attributes %}
+
+ .. rubric:: Attributes
+
+ .. autosummary::
+ {% for item in attributes %}
+ ~{{ name }}.{{ item }}
+ {%- endfor %}
+
+ {% endif %}
+ {% endblock %}
+
+ {% block methods_documentation %}
+ {% if methods %}
+
+ .. rubric:: Methods Documentation
+
+ {% for item in methods %}
+ .. automethod:: {{ item }}
+ {%- endfor %}
+
+ {% endif %}
+ {% endblock %}
+
+ {% block attributes_documentation %}
+ {% if attributes %}
+
+ .. rubric:: Attributes Documentation
+
+ {% for item in attributes %}
+ .. autoattribute:: {{ item }}
+ {%- endfor %}
+
+ {% endif %}
+ {% endblock %}
+
Review comment:
This is needed to let `autusummary` plugin document the methods in a class. For example, when we use this template, it describes methods documentation on the bottom. See [pyspark.ml.Transformer](https://hyukjin-spark.readthedocs.io/en/stable/reference/api/pyspark.ml.Transformer.html#pyspark.ml.Transformer) as an example.
Without this template, it only lists the methods and attributes without showing the documentation in details. See [pyspark.sql.DataFrameNaFunctions](https://hyukjin-spark.readthedocs.io/en/stable/reference/api/pyspark.sql.DataFrameNaFunctions.html#pyspark.sql.DataFrameNaFunctions) as an example.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662549136
**[Test build #126335 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126335/testReport)** for PR 29188 at commit [`54ffa45`](https://github.com/apache/spark/commit/54ffa45c195e4479d1d9eb7bbcab4d49825560cf).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662519415
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662957151
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662393010
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-664332877
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662858674
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662883974
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126396/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662519424
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126336/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-664179480
**[Test build #126627 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126627/testReport)** for PR 29188 at commit [`d6d0117`](https://github.com/apache/spark/commit/d6d011737aba77e7eca41c1b65d6588764856797).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662885671
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662882128
**[Test build #126402 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126402/testReport)** for PR 29188 at commit [`aa574d2`](https://github.com/apache/spark/commit/aa574d246e8d471004a00fc91615f94b55890218).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662882502
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662550896
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662851350
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662394309
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-663307556
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-663009026
**[Test build #126406 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126406/testReport)** for PR 29188 at commit [`8feeb13`](https://github.com/apache/spark/commit/8feeb13ff22e41dbc68f1806601db851e2dbf9d3).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662883907
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon edited a comment on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
HyukjinKwon edited a comment on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662966732
I believe this is ready for a look or possibly ready to go.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-663009803
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662436635
**[Test build #126336 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126336/testReport)** for PR 29188 at commit [`1c6fe6c`](https://github.com/apache/spark/commit/1c6fe6c04e5680452b9aa27ba296e2471a54e650).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662879591
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662858674
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662372392
@BryanCutler, @huaxingao, @ueshin, @viirya, @srowen, @dongjoon-hyun, @WeichenXu123, @zhengruifeng, @holdenk, @zero323, can you guys take a look when you are available?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662547714
**[Test build #126334 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126334/testReport)** for PR 29188 at commit [`7567003`](https://github.com/apache/spark/commit/75670034671ea7cff562cb1db4079cf0924933a7).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662393010
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662851350
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-664179480
**[Test build #126627 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126627/testReport)** for PR 29188 at commit [`d6d0117`](https://github.com/apache/spark/commit/d6d011737aba77e7eca41c1b65d6588764856797).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #29188:
URL: https://github.com/apache/spark/pull/29188
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662392331
**[Test build #126330 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126330/testReport)** for PR 29188 at commit [`c448b23`](https://github.com/apache/spark/commit/c448b23f1a711a1220c2197db663be4d11854e0c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662519415
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #29188:
URL: https://github.com/apache/spark/pull/29188#discussion_r458688852
##########
File path: python/docs/source/conf.py
##########
@@ -14,12 +14,23 @@
import sys
import os
+import shutil
# If extensions (or modules to document with autodoc) are in another directory,
# add these directories to sys.path here. If the directory is relative to the
# documentation root, use os.path.abspath to make it absolute, like shown here.
sys.path.insert(0, os.path.abspath('.'))
+# Remove previously generated rst files. Ignore errors just in case it stops
+# generating whole docs.
+shutil.rmtree(
+ "%s/reference/api" % os.path.dirname(os.path.abspath(__file__)), ignore_errors=True)
Review comment:
`autosummary` generates RST files but don't remove it back. Here we always remove the generated RST files so the leftover doesn't cause any side effect.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662885671
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon removed a comment on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
HyukjinKwon removed a comment on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662844528
I double checked. I believe it should be ready for a look and possibly good to go.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662879016
**[Test build #126401 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126401/testReport)** for PR 29188 at commit [`c83850b`](https://github.com/apache/spark/commit/c83850ba35fda140265a24ce3e8d01bf5bdc8a8f).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662550896
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-663009803
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662548651
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662937861
**[Test build #126406 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126406/testReport)** for PR 29188 at commit [`8feeb13`](https://github.com/apache/spark/commit/8feeb13ff22e41dbc68f1806601db851e2dbf9d3).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #29188:
URL: https://github.com/apache/spark/pull/29188#discussion_r459159755
##########
File path: dev/requirements.txt
##########
@@ -3,3 +3,4 @@ jira==1.0.3
PyGithub==1.26.0
Unidecode==0.04.19
sphinx
+pydata_sphinx_theme
Review comment:
This PR is already pinning it in `dev/create-release/spark-rm/Dockerfile` for release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662957151
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662843476
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662431440
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-664179173
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662956639
**[Test build #126404 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126404/testReport)** for PR 29188 at commit [`aa200ec`](https://github.com/apache/spark/commit/aa200ec176ad217429a4a91d402d72d89530cf07).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662436635
**[Test build #126336 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126336/testReport)** for PR 29188 at commit [`1c6fe6c`](https://github.com/apache/spark/commit/1c6fe6c04e5680452b9aa27ba296e2471a54e650).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] holdenk commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
holdenk commented on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662437518
Excited to see the site improve, I’ll take some time to review it this week.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662367871
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662427304
**[Test build #126334 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126334/testReport)** for PR 29188 at commit [`7567003`](https://github.com/apache/spark/commit/75670034671ea7cff562cb1db4079cf0924933a7).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #29188:
URL: https://github.com/apache/spark/pull/29188#discussion_r459184480
##########
File path: dev/requirements.txt
##########
@@ -3,3 +3,4 @@ jira==1.0.3
PyGithub==1.26.0
Unidecode==0.04.19
sphinx
+pydata_sphinx_theme
Review comment:
I thought about this for a while actually especially given the discussion we had before.
`pydata_sphinx_theme` is actually relatively very new and it has [frequent releases](https://github.com/pandas-dev/pydata-sphinx-theme/tags). I would like to not pin the versions for now to promote dev people to keep it up to date.. maybe we could see how it goes if that sounds fine to you as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-663307236
**[Test build #126449 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126449/testReport)** for PR 29188 at commit [`d6d0117`](https://github.com/apache/spark/commit/d6d011737aba77e7eca41c1b65d6588764856797).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-664179944
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662844528
I double checked. I believe it should be ready for a look and possibly good to go.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662883731
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-663341971
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662789431
> I wonder if there is some non-hacky way to organize functions into logical groups, similarly to what ScalaDoc does.
I tried hard but looked difficult to do. I will take a look one more time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662858236
**[Test build #126394 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126394/testReport)** for PR 29188 at commit [`a799f91`](https://github.com/apache/spark/commit/a799f91155560f69450b92668f20e8079eaf5deb).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662428040
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662879591
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-664209358
Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662883732
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662392331
**[Test build #126330 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126330/testReport)** for PR 29188 at commit [`c448b23`](https://github.com/apache/spark/commit/c448b23f1a711a1220c2197db663be4d11854e0c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662394309
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662966732
I believe this is ready for a look or possibly read to go.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-664179944
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-664179490
I will merge and go ahead given that there are multiple positive feedback here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662435411
**[Test build #126335 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126335/testReport)** for PR 29188 at commit [`54ffa45`](https://github.com/apache/spark/commit/54ffa45c195e4479d1d9eb7bbcab4d49825560cf).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-663307556
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662428040
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-664209546
Let me know if you guys have any concern on this. I will be working on this to complete the other pages for a while.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #29188:
URL: https://github.com/apache/spark/pull/29188#discussion_r459184480
##########
File path: dev/requirements.txt
##########
@@ -3,3 +3,4 @@ jira==1.0.3
PyGithub==1.26.0
Unidecode==0.04.19
sphinx
+pydata_sphinx_theme
Review comment:
I thought about this for a while actually especially given the discussion we had before.
`pydata_sphinx_theme` is actually relatively very new and it has [frequent releases](https://github.com/pandas-dev/pydata-sphinx-theme/tags). I would like to not pin the versions for now and see how it goes if that sounds fine to you as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662851166
**[Test build #126390 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126390/testReport)** for PR 29188 at commit [`8a6d316`](https://github.com/apache/spark/commit/8a6d31645118cd96cf1524d06e076bac3d7e14fe).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662938220
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-663307236
**[Test build #126449 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126449/testReport)** for PR 29188 at commit [`d6d0117`](https://github.com/apache/spark/commit/d6d011737aba77e7eca41c1b65d6588764856797).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662860952
**[Test build #126396 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126396/testReport)** for PR 29188 at commit [`4b918db`](https://github.com/apache/spark/commit/4b918db11ecab000f4980959e2e79a082f45756e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-663341579
**[Test build #126449 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126449/testReport)** for PR 29188 at commit [`d6d0117`](https://github.com/apache/spark/commit/d6d011737aba77e7eca41c1b65d6588764856797).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662393017
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126330/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #29188:
URL: https://github.com/apache/spark/pull/29188#discussion_r459159613
##########
File path: dev/requirements.txt
##########
@@ -3,3 +3,4 @@ jira==1.0.3
PyGithub==1.26.0
Unidecode==0.04.19
sphinx
+pydata_sphinx_theme
Review comment:
Maybe, is `pydata_sphinx_theme==0.3.1` better to prevent accidental HTML corruption in the future because HTML code and CSS style is impossible to verify automatically.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29188:
URL: https://github.com/apache/spark/pull/29188#issuecomment-662937861
**[Test build #126406 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126406/testReport)** for PR 29188 at commit [`8feeb13`](https://github.com/apache/spark/commit/8feeb13ff22e41dbc68f1806601db851e2dbf9d3).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org