You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/08/26 01:08:18 UTC
[GitHub] [incubator-yunikorn-scheduler-interface] yangwwei opened a new pull request #25: [YUNIKORN-374] Update GRPC version to 1.26.0
yangwwei opened a new pull request #25:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/25
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-scheduler-interface] yangwwei commented on a change in pull request #25: [YUNIKORN-374] Update GRPC version to 1.26.0
Posted by GitBox <gi...@apache.org>.
yangwwei commented on a change in pull request #25:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/25#discussion_r477615349
##########
File path: go.mod
##########
@@ -22,6 +22,6 @@ module github.com/apache/incubator-yunikorn-scheduler-interface
go 1.12
require (
- github.com/golang/protobuf v1.3.1
- google.golang.org/grpc v1.21.1
+ github.com/golang/protobuf v1.3.2
Review comment:
Thanks @wilfred-s . I think it makes sense to keep them in sync.
I have modified the Makefile accordingly, to make sure the protobuf version is consistent with what's been defined in the `go.mod`. Please help to review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-scheduler-interface] wilfred-s commented on a change in pull request #25: [YUNIKORN-374] Update GRPC version to 1.26.0
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on a change in pull request #25:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/25#discussion_r477266410
##########
File path: go.mod
##########
@@ -22,6 +22,6 @@ module github.com/apache/incubator-yunikorn-scheduler-interface
go 1.12
require (
- github.com/golang/protobuf v1.3.1
- google.golang.org/grpc v1.21.1
+ github.com/golang/protobuf v1.3.2
Review comment:
In the Makefile we clone and checkout protobuf 1.3.1.
Changing the version here is only half of what should be done. We really should pass the version from the `go.mod` file via the root Makefile into the `lib/go` Makefile.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-scheduler-interface] wilfred-s closed pull request #25: [YUNIKORN-374] Update GRPC version to 1.26.0
Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #25:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/25
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org