[jira] [Commented] (TINKERPOP-2727) HasContainer should allow a null key

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TINKERPOP-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17513699#comment-17513699 ] 

ASF GitHub Bot commented on TINKERPOP-2727:
-------------------------------------------

spmallette opened a new pull request #1596:
URL: https://github.com/apache/tinkerpop/pull/1596


   https://issues.apache.org/jira/browse/TINKERPOP-2727
   
   Seems to apply when the null is on the first arg of a two arg overload - it tries to call on has(T,...) which ends in IllegalArgumentException, which never quite surfaces to the JavaTranslator properly. Another example of why bytecode is lacking and why gremlin-language is likely going to be its successor.
   
   All tests pass with `docker/build.sh -t -n -i`
   
   VOTE +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> HasContainer should allow a null key
> ------------------------------------
>
>                 Key: TINKERPOP-2727
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2727
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: process
>    Affects Versions: 3.5.2
>            Reporter: Florian Hockmann
>            Priority: Minor
>
> TINKERPOP-2605 changed {{null}} semantics to allow {{null}} as an argument in more places so that {{has(null)}} should not throw a NPE any more and instead filter all traversers out.
> {{HasContainer}} however still throws a NPE if the {{key}} is {{{}null{}}}.
> I discovered this when trying to update JanusGraph [as that folds in a {{HasContainer}} like this|https://github.com/JanusGraph/janusgraph/blob/4246d49cee46d549d752515f3956cd2d59f1fd0a/janusgraph-core/src/main/java/org/janusgraph/graphdb/tinkerpop/optimize/step/HasStepFolder.java#L266] which leads to the NPE and thus failing tests.
> The same behavior can also be produced with just TinkerGraph and for example the following traversals:
> {code:java}
> g.V().has(null, 1)
> g.V().has(null, P.neq(null)){code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)