You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/24 16:39:15 UTC
[GitHub] [arrow] wesm opened a new pull request, #13225: ARROW-16643: [C++] Fix warnings for clang-14
wesm opened a new pull request, #13225:
URL: https://github.com/apache/arrow/pull/13225
The following code in arrow/util/small_vector_benchmark.cc generates `-Wreturn-stack-address` in clang-14. It might be better to fix but suppressing for now:
```
template <typename Vector>
ARROW_NOINLINE int64_t ConsumeVector(Vector v) {
return reinterpret_cast<intptr_t>(v.data());
}
template <typename Vector>
ARROW_NOINLINE int64_t IngestVector(const Vector& v) {
return reinterpret_cast<intptr_t>(v.data());
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13225: ARROW-16643: [C++] Fix warnings for clang-14
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13225:
URL: https://github.com/apache/arrow/pull/13225#issuecomment-1136153017
:warning: Ticket **has not been started in JIRA**, please click 'Start Progress'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13225: ARROW-16643: [C++] Fix warnings for clang-14
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13225:
URL: https://github.com/apache/arrow/pull/13225#issuecomment-1136152977
https://issues.apache.org/jira/browse/ARROW-16643
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm closed pull request #13225: ARROW-16643: [C++] Fix warnings for clang-14
Posted by GitBox <gi...@apache.org>.
lidavidm closed pull request #13225: ARROW-16643: [C++] Fix warnings for clang-14
URL: https://github.com/apache/arrow/pull/13225
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #13225: ARROW-16643: [C++] Fix warnings for clang-14
Posted by GitBox <gi...@apache.org>.
lidavidm commented on PR #13225:
URL: https://github.com/apache/arrow/pull/13225#issuecomment-1136319388
That AppVeyor issue should be fixed by https://github.com/apache/arrow/pull/13191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #13225: ARROW-16643: [C++] Fix warnings for clang-14
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #13225:
URL: https://github.com/apache/arrow/pull/13225#issuecomment-1136451944
Benchmark runs are scheduled for baseline = dd84c0f68c6f898e3a02bb0623500e3f165f80d4 and contender = 7adda73dc4ef6f28f8e5701eb4be1dc9526c0e1b. 7adda73dc4ef6f28f8e5701eb4be1dc9526c0e1b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/f20214b72a6847938d9625435d127a71...a089b216886048579f94f7c687209b11/)
[Failed :arrow_down:0.39% :arrow_up:1.87%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/3d168fa0ade343feac150722d9afdd56...3ae3178ba3d24e8b983b92be5e2b02b1/)
[Failed :arrow_down:0.74% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/bbade04a7e4f4aa09f1bc11a54e63b95...9260031769da4ea6b2fbd9ee5efdd39d/)
[Finished :arrow_down:0.32% :arrow_up:1.89%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/ab6fc9119e874c1fa64a0bdc1a8b92ee...073db3a11b4a494fa11d4a2071402765/)
Buildkite builds:
[Finished] [`7adda73d` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/816)
[Failed] [`7adda73d` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/815)
[Failed] [`7adda73d` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/805)
[Finished] [`7adda73d` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/819)
[Finished] [`dd84c0f6` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/815)
[Failed] [`dd84c0f6` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/813)
[Failed] [`dd84c0f6` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/803)
[Finished] [`dd84c0f6` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/818)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #13225: ARROW-16643: [C++] Fix warnings for clang-14
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #13225:
URL: https://github.com/apache/arrow/pull/13225#issuecomment-1136452065
['Python', 'R'] benchmarks have high level of regressions.
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/bbade04a7e4f4aa09f1bc11a54e63b95...9260031769da4ea6b2fbd9ee5efdd39d/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org