You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/18 11:01:41 UTC
[GitHub] [apisix] Miss-you opened a new pull request #2785: fix: format the string.find
Miss-you opened a new pull request #2785:
URL: https://github.com/apache/apisix/pull/2785
string_find -> str_find
find_str -> str_find
global string.find -> local str_find
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
* [ ] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #2785: fix: format the string.find
Posted by GitBox <gi...@apache.org>.
spacewander commented on pull request #2785:
URL: https://github.com/apache/apisix/pull/2785#issuecomment-729611172
Since you already do the refactor, would it better if you use `core.string.find` instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #2785: fix: format the string.find
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #2785:
URL: https://github.com/apache/apisix/pull/2785#discussion_r526004932
##########
File path: apisix/discovery/eureka.lua
##########
@@ -28,7 +28,7 @@ local ngx = ngx
local ngx_timer_at = ngx.timer.at
local ngx_timer_every = ngx.timer.every
local string_sub = string.sub
-local string_find = string.find
+local str_find = string.find
Review comment:
Please fix the indentation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis merged pull request #2785: fix: format the string.find
Posted by GitBox <gi...@apache.org>.
membphis merged pull request #2785:
URL: https://github.com/apache/apisix/pull/2785
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org