You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/31 13:42:21 UTC
[GitHub] [airflow] potiuk opened a new pull request #22649: Fix passing string to upgrade-to-newer-dependencies
potiuk opened a new pull request #22649:
URL: https://github.com/apache/airflow/pull/22649
This change fixes passing upgrade-to-newer-dependencies
parameter as string. The previous fix (#22597) did not actually
fix handling of the parameter passed and "false" passed as string
was considered as "true" :)
This should speed UP most CI builds immensely.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22649: Fix passing string to upgrade-to-newer-dependencies
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #22649:
URL: https://github.com/apache/airflow/pull/22649#issuecomment-1084596369
LAst one to get most of the CI builds to ~ 1 minute instead of 7 minutes, I think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22649: Fix passing string to upgrade-to-newer-dependencies
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #22649:
URL: https://github.com/apache/airflow/pull/22649#issuecomment-1084595422
I looked at the speed of builds @Bowrna and I noticed that I have not fixed the actual problem last time :).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #22649: Fix passing string to upgrade-to-newer-dependencies
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #22649:
URL: https://github.com/apache/airflow/pull/22649
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22649: Fix passing string to upgrade-to-newer-dependencies
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #22649:
URL: https://github.com/apache/airflow/pull/22649#issuecomment-1084600945
Yep: https://github.com/apache/airflow/runs/5772041073?check_suite_focus=true - 1m 10s instead of `main`. @eladkal - I believe this was also the reason for the Arango problem (upgrading stuff where it was not needed). So we should merge that one and rebase Arango to verify.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org