You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/09 10:23:26 UTC
[GitHub] [doris] yiguolei opened a new pull request, #13222: [chore](release build) copy license and notice file to output folder and strip debug info from meta tool
yiguolei opened a new pull request, #13222:
URL: https://github.com/apache/doris/pull/13222
# Proposed changes
When build a doris release, the release manager need do a lot of works and sometimes he or she may forget something. And sometimes the release maybe not fully tested because the release is build manually by the release manager and the env maybe wrong. In this PR do follow things:
1. add licenses and notices file to our binary folder as default so that the release manager do not need copy them manually.
2. strip debug info from meta tool by default since debug info is useless for meta tool.
After this we could get the binary from github pipeline in the future and the binary is fully tested and it is more stable.
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
4. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
5. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
6. Does it need to update dependencies:
- [ ] Yes
- [ ] No
7. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13222: [chore](release build) copy license and notice file to output folder and strip debug info from meta tool
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13222:
URL: https://github.com/apache/doris/pull/13222#issuecomment-1272578114
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13222: [chore](release build) copy license and notice file to output folder and strip debug info from meta tool
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13222:
URL: https://github.com/apache/doris/pull/13222#issuecomment-1272578104
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13222: [chore](release build) copy license and notice file to output folder and strip debug info from meta tool
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13222:
URL: https://github.com/apache/doris/pull/13222#issuecomment-1272509372
#### `sh-checker report`
To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/3213792704") output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' returned error 1 finding the following syntactical issues:
----------
In build.sh line 102:
cp -r -p ${DORIS_HOME}/NOTICE.txt "$1/"
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
cp -r -p "${DORIS_HOME}"/NOTICE.txt "$1/"
In build.sh line 103:
cp -r -p ${DORIS_HOME}/dist/LICENSE-dist.txt "$1/"
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
cp -r -p "${DORIS_HOME}"/dist/LICENSE-dist.txt "$1/"
In build.sh line 104:
cp -r -p ${DORIS_HOME}/dist/licenses "$1/"
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
cp -r -p "${DORIS_HOME}"/dist/licenses "$1/"
In build.sh line 456:
copy_common_files ${DORIS_OUTPUT}/fe/
^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
copy_common_files "${DORIS_OUTPUT}"/fe/
In build.sh line 502:
copy_common_files ${DORIS_OUTPUT}/be/
^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
copy_common_files "${DORIS_OUTPUT}"/be/
In build.sh line 514:
copy_common_files ${DORIS_OUTPUT}/apache_hdfs_broker/
^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
copy_common_files "${DORIS_OUTPUT}"/apache_hdfs_broker/
For more information:
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
----------
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' found no issues.
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #13222: [chore](release build) copy license and notice file to output folder and strip debug info from meta tool
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #13222:
URL: https://github.com/apache/doris/pull/13222
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org