[GitHub] cordova-android pull request: CB-3360 Set custom User-Agent

[agrieve <gi...@git.apache.org>]

Github user agrieve commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/162#discussion_r27606969
  
    --- Diff: framework/src/org/apache/cordova/engine/SystemWebViewEngine.java ---
    @@ -199,7 +199,19 @@ private void initWebViewSettings() {
             
             // Fix for CB-1405
             // Google issue 4641
    -        settings.getUserAgentString();
    +        String defaultUserAgent = settings.getUserAgentString();
    +
    +        // Fix for CB-3360
    +        String overrideUserAgent = getCordovaWebView().getPreferences().getString("OverrideUserAgent", null);
    --- End diff --
    
    I'd like to avoid circular dependency if possible on CordovaWebView.
    
    Rather than depending on CordovaWebView here, could you save the instance of CordovaPreferences passed to the constructor and use that instead? Would also need to add CordovaPreferences as a 2nd arg to the other constructor as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org