You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by th...@apache.org on 2020/11/29 02:59:54 UTC

[tapestry-5] branch master updated: Improving tapestry-javadoc exception handling

This is an automated email from the ASF dual-hosted git repository.

thiagohp pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tapestry-5.git


The following commit(s) were added to refs/heads/master by this push:
     new f329f36  Improving tapestry-javadoc exception handling
f329f36 is described below

commit f329f3639b13634fe8b8b36f0b5b6584f5217f6d
Author: Thiago H. de Paula Figueiredo <th...@arsmachina.com.br>
AuthorDate: Sat Nov 28 23:59:36 2020 -0300

    Improving tapestry-javadoc exception handling
---
 .../main/java/org/apache/tapestry5/javadoc/TapestryDocTaglet.java    | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tapestry-javadoc/src/main/java/org/apache/tapestry5/javadoc/TapestryDocTaglet.java b/tapestry-javadoc/src/main/java/org/apache/tapestry5/javadoc/TapestryDocTaglet.java
index 95b6752..3c609ad 100644
--- a/tapestry-javadoc/src/main/java/org/apache/tapestry5/javadoc/TapestryDocTaglet.java
+++ b/tapestry-javadoc/src/main/java/org/apache/tapestry5/javadoc/TapestryDocTaglet.java
@@ -113,7 +113,7 @@ public class TapestryDocTaglet implements Taglet, ClassDescriptionSource
             return writer.toString();
         } catch (Exception ex)
         {
-            System.err.println(ex);
+            ex.printStackTrace(System.err);
             System.exit(-1);
 
             return null; // unreachable
@@ -301,6 +301,9 @@ public class TapestryDocTaglet implements Taglet, ClassDescriptionSource
                         classDoc.getQualifiedName().toString(),
                         JavaFileObject.Kind.SOURCE);
 
+        if (sourceFileObject == null) {
+            throw new RuntimeException("Source file object not found for " + classDoc.getQualifiedName().toString());
+        }
         File sourceFile = new File(sourceFileObject.toUri());
 
         // The .xdoc file will be adjacent to the sourceFile