You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/07/06 00:40:05 UTC
[GitHub] [arrow-datafusion] houqp opened a new pull request #688: run ballista integration test in CI
houqp opened a new pull request #688:
URL: https://github.com/apache/arrow-datafusion/pull/688
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes https://github.com/apache/arrow-datafusion/issues/321
# Rationale for this change
Avoid ballista integration test regressions automatically.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
New CI job and updated integration test script to make it runnable within CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #688: run ballista integration test in CI
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #688:
URL: https://github.com/apache/arrow-datafusion/pull/688#issuecomment-958152933
Closing a seemingly stale PR -- please reopen if that was a mistake.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] houqp commented on pull request #688: run ballista integration test in CI
Posted by GitBox <gi...@apache.org>.
houqp commented on pull request #688:
URL: https://github.com/apache/arrow-datafusion/pull/688#issuecomment-874529348
Turns out release build made a big difference for test run time, in debug mode, job runtime went from 28m to almost 1 hour.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] houqp commented on pull request #688: run ballista integration test in CI
Posted by GitBox <gi...@apache.org>.
houqp commented on pull request #688:
URL: https://github.com/apache/arrow-datafusion/pull/688#issuecomment-874423832
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on pull request #688: run ballista integration test in CI
Posted by GitBox <gi...@apache.org>.
andygrove commented on pull request #688:
URL: https://github.com/apache/arrow-datafusion/pull/688#issuecomment-894901179
Thanks @houqp for persevering with this! I will try and review in the next day or two.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] houqp commented on pull request #688: run ballista integration test in CI
Posted by GitBox <gi...@apache.org>.
houqp commented on pull request #688:
URL: https://github.com/apache/arrow-datafusion/pull/688#issuecomment-874423832
Integration test took 28m to run, compared to our main Rust test job which took 14m. I think we can cut down the build time by 10m if we avoid rebuilding the base image on every run. I am thinking we can host the pre-built base image with public github docker registry, thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #688: run ballista integration test in CI
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #688:
URL: https://github.com/apache/arrow-datafusion/pull/688#issuecomment-951817464
Marking PRs that haven't had activity in over a month as 'stale-pr' to help me filter the list. Please remove the label or let me know if "stale" is not the correct designation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] houqp commented on pull request #688: run ballista integration test in CI
Posted by GitBox <gi...@apache.org>.
houqp commented on pull request #688:
URL: https://github.com/apache/arrow-datafusion/pull/688#issuecomment-894748609
Finally got cargo cache working within docker builds, this is way more complicated than I initially expected...
Ballista integration test run now completes roughly 1 minute faster than our full Rust workspace test suit when there is a cache hit. I think we should be good for now. As a bonus, subsequent ballista docker build should be a lot faster on local machine as well if buildx cache is enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jorgecarleitao commented on pull request #688: run ballista integration test in CI
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #688:
URL: https://github.com/apache/arrow-datafusion/pull/688#issuecomment-874429610
The build log is a bit unreadable in its current form. Could we trim the output?
I went through the build log and I am not sure having a pre-built image helps:
* 4m are spent in `apt-get install`ing.
* most of the time is spent building a `--release` binary. Do we need it to be a release build?
* we are not caching anything from cargo, like we do for the other builds
I suggest that we trim the time by caching the cargo build, which has no dependency on docker nor docker registry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #688: run ballista integration test in CI
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #688:
URL: https://github.com/apache/arrow-datafusion/pull/688#issuecomment-958152933
Closing a seemingly stale PR -- please reopen if that was a mistake.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jorgecarleitao commented on pull request #688: run ballista integration test in CI
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #688:
URL: https://github.com/apache/arrow-datafusion/pull/688#issuecomment-874429610
The build log is a bit unreadable in its current form. Could we trim the output?
I went through the build log and I am not sure having a pre-built image helps:
* 4m are spent in `apt-get install`ing.
* most of the time is spent building a `--release` binary. Do we need it to be a release build?
* we are not caching anything from cargo, like we do for the other builds
I suggest that we trim the time by caching the cargo build, which has no dependency on docker nor docker registry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on pull request #688: run ballista integration test in CI
Posted by GitBox <gi...@apache.org>.
andygrove commented on pull request #688:
URL: https://github.com/apache/arrow-datafusion/pull/688#issuecomment-874453682
Thanks @houqp it is great to see this being worked on :rocket:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on pull request #688: run ballista integration test in CI
Posted by GitBox <gi...@apache.org>.
andygrove commented on pull request #688:
URL: https://github.com/apache/arrow-datafusion/pull/688#issuecomment-874453682
Thanks @houqp it is great to see this being worked on :rocket:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on pull request #688: run ballista integration test in CI
Posted by GitBox <gi...@apache.org>.
andygrove commented on pull request #688:
URL: https://github.com/apache/arrow-datafusion/pull/688#issuecomment-881918975
The integration tests are crazy slow because the distributed query execution in Ballista is fundamentally broken (see https://github.com/apache/arrow-datafusion/issues/707) and fragments of the query are executed multiple times. I am hoping to have this all fixed in the next few weeks (I only have time at weekends to work on this).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb closed pull request #688: run ballista integration test in CI
Posted by GitBox <gi...@apache.org>.
alamb closed pull request #688:
URL: https://github.com/apache/arrow-datafusion/pull/688
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] houqp commented on pull request #688: run ballista integration test in CI
Posted by GitBox <gi...@apache.org>.
houqp commented on pull request #688:
URL: https://github.com/apache/arrow-datafusion/pull/688#issuecomment-895764931
converting PR back to draft mode since I noticed buildx just released a native github action backend that we can leverage to keep layer cache size from growing unbounded. i will give https://github.com/docker/build-push-action/blob/master/docs/advanced/cache.md#cache-backend-api a try this weekend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] houqp commented on pull request #688: run ballista integration test in CI
Posted by GitBox <gi...@apache.org>.
houqp commented on pull request #688:
URL: https://github.com/apache/arrow-datafusion/pull/688#issuecomment-874450970
You are right, base image build took around 5 mins, then it's 20 mins for ballista build and 4 mins for running the integration tests. I will look into optimization for the ballista build step.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb closed pull request #688: run ballista integration test in CI
Posted by GitBox <gi...@apache.org>.
alamb closed pull request #688:
URL: https://github.com/apache/arrow-datafusion/pull/688
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org