You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by GitBox <gi...@apache.org> on 2021/09/17 11:18:44 UTC

[GitHub] [datasketches-java] davecromberge opened a new pull request #362: Memory2 javadoc fixes and Github matrix testing

davecromberge opened a new pull request #362:
URL: https://github.com/apache/datasketches-java/pull/362


   The Teletype `<tt>` tag has been deprecated in HTML 5 and was resulting in Javadoc generation errors on this branch.  The official HTML documentation recommends using alternatives such as `<samp />` or `<code />` instead.
   This PR replaces `<tt />` usages with `<code />`.
   
   Finally, matrix testing support has been added to the build to run the tests against Java 8-13.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org


[GitHub] [datasketches-java] leerho commented on pull request #362: Memory2 javadoc fixes and Github matrix testing

Posted by GitBox <gi...@apache.org>.
leerho commented on pull request #362:
URL: https://github.com/apache/datasketches-java/pull/362#issuecomment-921920553


   I will let you merge.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org


[GitHub] [datasketches-java] leerho commented on a change in pull request #362: Memory2 javadoc fixes and Github matrix testing

Posted by GitBox <gi...@apache.org>.
leerho commented on a change in pull request #362:
URL: https://github.com/apache/datasketches-java/pull/362#discussion_r711176123



##########
File path: .github/workflows/maven.yml
##########
@@ -3,7 +3,7 @@ name: Java Test Coverage with Maven, Coveralls
 on:
     pull_request:
     push:
-        branches: [ master ]
+        branches: [ master, Memory2-doc-fixes-gh-actions ]

Review comment:
       I assume this is temporary until we merge into master.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org


[GitHub] [datasketches-java] davecromberge commented on a change in pull request #362: Memory2 javadoc fixes and Github matrix testing

Posted by GitBox <gi...@apache.org>.
davecromberge commented on a change in pull request #362:
URL: https://github.com/apache/datasketches-java/pull/362#discussion_r711176750



##########
File path: .github/workflows/maven.yml
##########
@@ -3,7 +3,7 @@ name: Java Test Coverage with Maven, Coveralls
 on:
     pull_request:
     push:
-        branches: [ master ]
+        branches: [ master, Memory2-doc-fixes-gh-actions ]

Review comment:
       Good spot, this was for testing and I'll remove it now before merging.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org


[GitHub] [datasketches-java] davecromberge commented on pull request #362: Memory2 javadoc fixes and Github matrix testing

Posted by GitBox <gi...@apache.org>.
davecromberge commented on pull request #362:
URL: https://github.com/apache/datasketches-java/pull/362#issuecomment-921921277


   @leerho this merges into the Memory2 branch, a separate PR will be required for all the changes for Memory2.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org


[GitHub] [datasketches-java] davecromberge merged pull request #362: Memory2 javadoc fixes and Github matrix testing

Posted by GitBox <gi...@apache.org>.
davecromberge merged pull request #362:
URL: https://github.com/apache/datasketches-java/pull/362


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org