You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2021/03/09 08:33:39 UTC
[GitHub] [openwhisk-client-js] jbampton opened a new pull request #219: chore: fix spelling
jbampton opened a new pull request #219:
URL: https://github.com/apache/openwhisk-client-js/pull/219
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-client-js] rabbah edited a comment on pull request #219: chore: fix spelling
Posted by GitBox <gi...@apache.org>.
rabbah edited a comment on pull request #219:
URL: https://github.com/apache/openwhisk-client-js/pull/219#issuecomment-794124465
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-client-js] rabbah merged pull request #219: chore: fix spelling
Posted by GitBox <gi...@apache.org>.
rabbah merged pull request #219:
URL: https://github.com/apache/openwhisk-client-js/pull/219
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-client-js] rabbah commented on a change in pull request #219: chore: fix spelling
Posted by GitBox <gi...@apache.org>.
rabbah commented on a change in pull request #219:
URL: https://github.com/apache/openwhisk-client-js/pull/219#discussion_r590522825
##########
File path: README.md
##########
@@ -461,7 +461,7 @@ The following optional parameters are supported:
- `params` - object containing default parameters for the action (default: `{}`)
- `annotations` - object containing annotations for the action (default: `{}`)
- `limits` - object containing limits for the action (default: `{}`)
-- `version` - set semantic version of the action. If parameter is empty when create new action openwisk generate 0.0.1 value when update an action increase the patch version.
+- `version` - set semantic version of the action. If parameter is empty when create new action openwhisk generate 0.0.1 value when update an action increase the patch version.
Review comment:
```suggestion
```
##########
File path: README.md
##########
@@ -435,7 +435,7 @@ The following optional parameters are supported:
- `annotations` - object containing annotations for the action (default: `{}`)
- `limits` - object containing limits for the action (default: `{}`)
- `kind` - runtime environment parameter, ignored when `action` is an object (default: `nodejs:default`)
-- `version` - set semantic version of the action. If parameter is empty when create new action openwisk generate 0.0.1 value when update an action increase the patch version.
+- `version` - set semantic version of the action. If parameter is empty when create new action openwhisk generate 0.0.1 value when update an action increase the patch version.
Review comment:
```suggestion
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-client-js] jbampton commented on pull request #219: chore: fix spelling
Posted by GitBox <gi...@apache.org>.
jbampton commented on pull request #219:
URL: https://github.com/apache/openwhisk-client-js/pull/219#issuecomment-795328271
Thanks for merging them all in @rabbah 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-client-js] rabbah commented on pull request #219: chore: fix spelling
Posted by GitBox <gi...@apache.org>.
rabbah commented on pull request #219:
URL: https://github.com/apache/openwhisk-client-js/pull/219#issuecomment-794124465
_If you merge one in, I will come back stronger with 2 !! _
or 2 dozen :D Thanks for all the PRs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-client-js] rabbah commented on a change in pull request #219: chore: fix spelling
Posted by GitBox <gi...@apache.org>.
rabbah commented on a change in pull request #219:
URL: https://github.com/apache/openwhisk-client-js/pull/219#discussion_r590305515
##########
File path: README.md
##########
@@ -435,7 +435,7 @@ The following optional parameters are supported:
- `annotations` - object containing annotations for the action (default: `{}`)
- `limits` - object containing limits for the action (default: `{}`)
- `kind` - runtime environment parameter, ignored when `action` is an object (default: `nodejs:default`)
-- `version` - set semantic version of the action. If parameter is empty when create new action openwisk generate 0.0.1 value when update an action increase the patch version.
+- `version` - set semantic version of the action. If parameter is empty when create new action openwhisk generate 0.0.1 value when update an action increase the patch version.
Review comment:
Grammar needs more fixing here and casing for ow should be OpenWhisk.
Separately we should remove the reference to version. It is incorrect entirely.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org