[GitHub] spark pull request #13335: [SPARK-15580][SQL]Add ContinuousQueryInfo to make...

[marmbrus <gi...@git.apache.org>]

Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13335#discussion_r65409474
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/streaming/ContinuousQueryListener.scala ---
    @@ -69,27 +72,27 @@ abstract class ContinuousQueryListener {
     @Experimental
     object ContinuousQueryListener {
     
    -  /**
    -   * Base type of [[ContinuousQueryListener]] events.
    -   * @since 2.0.0
    -   */
    +  /** Base type of [[ContinuousQueryListener]] events */
    +  @JsonTypeInfo(
    +    use = JsonTypeInfo.Id.CLASS,
    +    include = JsonTypeInfo.As.PROPERTY,
    +    property = "@class")
       trait Event
     
    -  /**
    -   * Event representing the start of a query.
    -   * @since 2.0.0
    -   */
    -  class QueryStarted private[sql](val query: ContinuousQuery) extends Event
    +  /** Event representing the start of a query */
    +  class QueryStarted private[sql](val queryInfo: ContinuousQueryInfo) extends Event
     
    -  /**
    -   * Event representing any progress updates in a query.
    -   * @since 2.0.0
    -   */
    -  class QueryProgress private[sql](val query: ContinuousQuery) extends Event
    +  /** Event representing any progress updates in a query */
    +  class QueryProgress private[sql](val queryInfo: ContinuousQueryInfo) extends Event
     
       /**
    -   * Event representing that termination of a query.
    -   * @since 2.0.0
    +   * Event representing that termination of a query
    +   *
    +   * @param queryInfo
    +   * @param exception The exception information of the [[ContinuousQuery]] if any. Otherwise, it
    +   *                  will be `None`.
        */
    -  class QueryTerminated private[sql](val query: ContinuousQuery) extends Event
    +  class QueryTerminated private[sql](
    +      val queryInfo: ContinuousQueryInfo,
    +      val exception: Option[String]) extends Event
    --- End diff --
    
    I don't think a string is enough here.  I think you need the stack trace also for it to be useful.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org