You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/11/26 10:32:00 UTC
[jira] [Commented] (MINIFICPP-685) Improve const correctness of
property getters
[ https://issues.apache.org/jira/browse/MINIFICPP-685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16698720#comment-16698720 ]
ASF GitHub Bot commented on MINIFICPP-685:
------------------------------------------
GitHub user arpadboda opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/449
MINIFICPP-685 - Improve const correctness of property getters
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/arpadboda/nifi-minifi-cpp MINIFICPP-685
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/449.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #449
----
commit 480929ac554b48ee717b19de4d589c0abfa14513
Author: Arpad Boda <ab...@...>
Date: 2018-11-26T10:30:20Z
MINIFICPP-685 - Improve const correctness of property getters
----
> Improve const correctness of property getters
> ---------------------------------------------
>
> Key: MINIFICPP-685
> URL: https://issues.apache.org/jira/browse/MINIFICPP-685
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: Arpad Boda
> Assignee: Arpad Boda
> Priority: Minor
> Fix For: 0.6.0
>
>
> Most of property getters are non-const, but they should be.
> Virtual functions shouldn't be modified in minor release, the rest can be fixed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)