You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by shinrich <gi...@git.apache.org> on 2017/03/07 19:06:03 UTC

[GitHub] trafficserver pull request #1547: Fix ssl hook state logic.

GitHub user shinrich opened a pull request:

    https://github.com/apache/trafficserver/pull/1547

    Fix ssl hook state logic.

    Was not correctly resetting the ssl hook state after the servername hooks.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shinrich/trafficserver fix_ssl_hook_state_transition

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafficserver/pull/1547.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1547
    
----
commit 0d3801cb39b0101b44365fb3d2e990ffc1287858
Author: Susan Hinrichs <sh...@ieee.org>
Date:   2017-03-07T19:04:12Z

    Fix ssl hook state logic.
    
    Was not correctly resetting the ssl hook state after the servername hooks.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1547: Fix ssl hook state logic.

Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:

    https://github.com/apache/trafficserver/pull/1547
  
    clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/254/ for details.
     



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1547: Fix ssl hook state logic.

Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:

    https://github.com/apache/trafficserver/pull/1547
  
    @persiaAziz This does not cherry-pick cleanly to 7.1.0, so if we want this for 7.1.x branch, can you please make another PR, against the 7.1.x branch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1547: Fix ssl hook state logic.

Posted by persiaAziz <gi...@git.apache.org>.
Github user persiaAziz commented on the issue:

    https://github.com/apache/trafficserver/pull/1547
  
    +1 
    Looks good


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1547: Fix ssl hook state logic.

Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:

    https://github.com/apache/trafficserver/pull/1547
  
    Intel CC build *successful*! See https://ci.trafficserver.apache.org/job/icc-github/122/ for details.
     



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1547: Fix ssl hook state logic.

Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:

    https://github.com/apache/trafficserver/pull/1547
  
    AU check *successful*! See https://ci.trafficserver.apache.org/job/autest-github/2/ for details.
     



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1547: Fix ssl hook state logic.

Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:

    https://github.com/apache/trafficserver/pull/1547
  
    FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1690/ for details.
     



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1547: Fix ssl hook state logic.

Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:

    https://github.com/apache/trafficserver/pull/1547
  
    Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1586/ for details.
     



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1547: Fix ssl hook state logic.

Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode closed the pull request at:

    https://github.com/apache/trafficserver/pull/1547


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1547: Fix ssl hook state logic.

Posted by persiaAziz <gi...@git.apache.org>.
Github user persiaAziz commented on the issue:

    https://github.com/apache/trafficserver/pull/1547
  
    @zwoop this does not cherry-pick cleanly because #1446  is not backported .. 
    #1610 backports both to 7.1.x


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---