You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@beehive.apache.org by "Joe Pemberton (JIRA)" <be...@incubator.apache.org> on 2005/01/31 21:52:29 UTC

[jira] Created: (BEEHIVE-216) Controls Test infrastructure should run tch with inheritall="true"

Controls Test infrastructure should run tch with inheritall="true"
------------------------------------------------------------------

         Key: BEEHIVE-216
         URL: http://issues.apache.org/jira/browse/BEEHIVE-216
     Project: Beehive
        Type: Bug
  Components: Controls  
    Reporter: Joe Pemberton
 Assigned to: Joe Pemberton 
    Priority: Minor


In order for TCH to inherit all tch.* properties (including filters), TCH needs to be run with inheritall="true".  Without this attribute, TCH will only pick up properties that are set on the command line (-Dtch.propname=value) and not any properties that are set programmatically.

If this change is made, the names of several other properties will need to be changed:
  tch.jar
  tch.schema.jar
  tch.xbean.jar

The preferred fix is to give these properties the "tchx" prefix:
  tchx.jar
  tchx.schema.jar
  tchx.xbean.jar

There may be some other conflicts - I will look into it.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Updated: (BEEHIVE-216) Controls Test infrastructure should run tch with inheritall="true"

Posted by "Steve Tocco (JIRA)" <be...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/BEEHIVE-216?page=history ]

Steve Tocco updated BEEHIVE-216:
--------------------------------

    Fix Version: V1

moving to v1 (if not needed for ship, please move to Fix For = TBD)

> Controls Test infrastructure should run tch with inheritall="true"
> ------------------------------------------------------------------
>
>          Key: BEEHIVE-216
>          URL: http://issues.apache.org/jira/browse/BEEHIVE-216
>      Project: Beehive
>         Type: Bug
>   Components: Controls
>     Reporter: Joe Pemberton
>     Assignee: Joe Pemberton
>     Priority: Minor
>      Fix For: V1

>
> In order for TCH to inherit all tch.* properties (including filters), TCH needs to be run with inheritall="true".  Without this attribute, TCH will only pick up properties that are set on the command line (-Dtch.propname=value) and not any properties that are set programmatically.
> If this change is made, the names of several other properties will need to be changed:
>   tch.jar
>   tch.schema.jar
>   tch.xbean.jar
> The preferred fix is to give these properties the "tchx" prefix:
>   tchx.jar
>   tchx.schema.jar
>   tchx.xbean.jar
> There may be some other conflicts - I will look into it.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Resolved: (BEEHIVE-216) Controls Test infrastructure should run tch with inheritall="true"

Posted by "Joe Pemberton (JIRA)" <be...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/BEEHIVE-216?page=all ]
     
Joe Pemberton resolved BEEHIVE-216:
-----------------------------------

    Resolution: Fixed

Fixed by r160236.

> Controls Test infrastructure should run tch with inheritall="true"
> ------------------------------------------------------------------
>
>          Key: BEEHIVE-216
>          URL: http://issues.apache.org/jira/browse/BEEHIVE-216
>      Project: Beehive
>         Type: Bug
>   Components: Controls
>     Reporter: Joe Pemberton
>     Assignee: Joe Pemberton
>     Priority: Minor
>      Fix For: V1

>
> In order for TCH to inherit all tch.* properties (including filters), TCH needs to be run with inheritall="true".  Without this attribute, TCH will only pick up properties that are set on the command line (-Dtch.propname=value) and not any properties that are set programmatically.
> If this change is made, the names of several other properties will need to be changed:
>   tch.jar
>   tch.schema.jar
>   tch.xbean.jar
> The preferred fix is to give these properties the "tchx" prefix:
>   tchx.jar
>   tchx.schema.jar
>   tchx.xbean.jar
> There may be some other conflicts - I will look into it.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (BEEHIVE-216) Controls Test infrastructure should run tch with inheritall="true"

Posted by "Joe Pemberton (JIRA)" <be...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/BEEHIVE-216?page=comments#action_58341 ]
     
Joe Pemberton commented on BEEHIVE-216:
---------------------------------------

Thanks for the input, Eddie.

However, TCH is invoked by an custom ant task that extends the Java task.  I will look into using a <propertyset> to match properties, but I am not sure if TCH will allow nested  <propertyset>'s. 

In this case, the only real problem with using inheritall is that if there are any properties with a prefix of "tch." that TCH does not recognize, it will die.  

  <tch tchHome="${tch.home}"
       testfile="${test-suite}"
       fork="true"
       classpathref="tch.run.classpath"
       failureproperty="run.failed"
       dir="${controls.test.root}">

> Controls Test infrastructure should run tch with inheritall="true"
> ------------------------------------------------------------------
>
>          Key: BEEHIVE-216
>          URL: http://issues.apache.org/jira/browse/BEEHIVE-216
>      Project: Beehive
>         Type: Bug
>   Components: Controls
>     Reporter: Joe Pemberton
>     Assignee: Joe Pemberton
>     Priority: Minor

>
> In order for TCH to inherit all tch.* properties (including filters), TCH needs to be run with inheritall="true".  Without this attribute, TCH will only pick up properties that are set on the command line (-Dtch.propname=value) and not any properties that are set programmatically.
> If this change is made, the names of several other properties will need to be changed:
>   tch.jar
>   tch.schema.jar
>   tch.xbean.jar
> The preferred fix is to give these properties the "tchx" prefix:
>   tchx.jar
>   tchx.schema.jar
>   tchx.xbean.jar
> There may be some other conflicts - I will look into it.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Commented: (BEEHIVE-216) Controls Test infrastructure should run tch with inheritall="true"

Posted by "Eddie O'Neil (JIRA)" <be...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/BEEHIVE-216?page=comments#action_58332 ]
     
Eddie O'Neil commented on BEEHIVE-216:
--------------------------------------

One thing to point out here...passing inheritAll="true" on <ant> calls in build files tends to tightly couple caller / callee build files and makes it hard over time to evolve / decouple / change things.

If possible, it can be more effective to create Ant <macro>s or to pass property file names that are explicitly passed along by the caller and then imported by the callee.

My $0.02...

> Controls Test infrastructure should run tch with inheritall="true"
> ------------------------------------------------------------------
>
>          Key: BEEHIVE-216
>          URL: http://issues.apache.org/jira/browse/BEEHIVE-216
>      Project: Beehive
>         Type: Bug
>   Components: Controls
>     Reporter: Joe Pemberton
>     Assignee: Joe Pemberton
>     Priority: Minor

>
> In order for TCH to inherit all tch.* properties (including filters), TCH needs to be run with inheritall="true".  Without this attribute, TCH will only pick up properties that are set on the command line (-Dtch.propname=value) and not any properties that are set programmatically.
> If this change is made, the names of several other properties will need to be changed:
>   tch.jar
>   tch.schema.jar
>   tch.xbean.jar
> The preferred fix is to give these properties the "tchx" prefix:
>   tchx.jar
>   tchx.schema.jar
>   tchx.xbean.jar
> There may be some other conflicts - I will look into it.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Closed: (BEEHIVE-216) Controls Test infrastructure should run tch with inheritall="true"

Posted by "Joe Pemberton (JIRA)" <be...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/BEEHIVE-216?page=all ]
     
Joe Pemberton closed BEEHIVE-216:
---------------------------------


> Controls Test infrastructure should run tch with inheritall="true"
> ------------------------------------------------------------------
>
>          Key: BEEHIVE-216
>          URL: http://issues.apache.org/jira/browse/BEEHIVE-216
>      Project: Beehive
>         Type: Bug
>   Components: Controls
>     Reporter: Joe Pemberton
>     Assignee: Joe Pemberton
>     Priority: Minor
>      Fix For: V1

>
> In order for TCH to inherit all tch.* properties (including filters), TCH needs to be run with inheritall="true".  Without this attribute, TCH will only pick up properties that are set on the command line (-Dtch.propname=value) and not any properties that are set programmatically.
> If this change is made, the names of several other properties will need to be changed:
>   tch.jar
>   tch.schema.jar
>   tch.xbean.jar
> The preferred fix is to give these properties the "tchx" prefix:
>   tchx.jar
>   tchx.schema.jar
>   tchx.xbean.jar
> There may be some other conflicts - I will look into it.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira