You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kapil Arya <ka...@mesosphere.io> on 2016/02/07 01:02:09 UTC
Re: Review Request 43263: Updated site building instructions in
site/README.md.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43263/
-----------------------------------------------------------
(Updated Feb. 6, 2016, 7:02 p.m.)
Review request for mesos and Ben Mahler.
Changes
-------
Updated readme.
Summary (updated)
-----------------
Updated site building instructions in site/README.md.
Repository: mesos
Description (updated)
-------
See summary.
Diffs (updated)
-----
site/README.md 71ca3ebbc645c6c188223895d12fb436b55038f9
Diff: https://reviews.apache.org/r/43263/diff/
Testing
-------
Thanks,
Kapil Arya
Re: Review Request 43263: Updated site building instructions in
site/README.md.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43263/#review118170
-----------------------------------------------------------
Patch looks great!
Reviews applied: [43120, 43121, 43122, 43263]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 7, 2016, 12:02 a.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43263/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2016, 12:02 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> site/README.md 71ca3ebbc645c6c188223895d12fb436b55038f9
>
> Diff: https://reviews.apache.org/r/43263/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 43263: Updated site building instructions in
site/README.md.
Posted by Kapil Arya <ka...@mesosphere.io>.
> On Feb. 7, 2016, 3:29 p.m., Ben Mahler wrote:
> > site/README.md, line 11
> > <https://reviews.apache.org/r/43263/diff/2/?file=1237038#file1237038line11>
> >
> > Conflicting version numbers of what? Seems a bit vague?
Elaborated a bit.
> On Feb. 7, 2016, 3:29 p.m., Ben Mahler wrote:
> > site/README.md, line 23
> > <https://reviews.apache.org/r/43263/diff/2/?file=1237038#file1237038line23>
> >
> > Could you also add this to the release guide so folks don't forget?
Create a new RR: https://reviews.apache.org/r/43263/
> On Feb. 7, 2016, 3:29 p.m., Ben Mahler wrote:
> > site/README.md, lines 61-88
> > <https://reviews.apache.org/r/43263/diff/2/?file=1237038#file1237038line61>
> >
> > Thanks! Next step will be to script this up :)
> >
> > One step at a time.. :)
Yup :).
> On Feb. 7, 2016, 3:29 p.m., Ben Mahler wrote:
> > site/README.md, lines 73-74
> > <https://reviews.apache.org/r/43263/diff/2/?file=1237038#file1237038line73>
> >
> > Meaning, if publish doesn't contain an api directory, or? How does one check this?
Let's keep it as is for now and we can handle it when we automate the steps later.
- Kapil
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43263/#review118186
-----------------------------------------------------------
On Feb. 7, 2016, 7:33 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43263/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2016, 7:33 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> site/README.md 71ca3ebbc645c6c188223895d12fb436b55038f9
>
> Diff: https://reviews.apache.org/r/43263/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 43263: Updated site building instructions in
site/README.md.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43263/#review118186
-----------------------------------------------------------
Fix it, then Ship it!
site/README.md (line 11)
<https://reviews.apache.org/r/43263/#comment179412>
Conflicting version numbers of what? Seems a bit vague?
site/README.md (line 23)
<https://reviews.apache.org/r/43263/#comment179414>
Could you also add this to the release guide so folks don't forget?
site/README.md (lines 61 - 88)
<https://reviews.apache.org/r/43263/#comment179417>
Thanks! Next step will be to script this up :)
One step at a time.. :)
site/README.md (lines 73 - 74)
<https://reviews.apache.org/r/43263/#comment179415>
Meaning, if publish doesn't contain an api directory, or? How does one check this?
site/README.md (lines 86 - 87)
<https://reviews.apache.org/r/43263/#comment179416>
Could you include a "-m <MESSAGE>" here so that people are including messages when they make commits?
- Ben Mahler
On Feb. 7, 2016, 12:02 a.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43263/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2016, 12:02 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> site/README.md 71ca3ebbc645c6c188223895d12fb436b55038f9
>
> Diff: https://reviews.apache.org/r/43263/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 43263: Updated site building instructions in
site/README.md.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43263/
-----------------------------------------------------------
(Updated Feb. 7, 2016, 7:33 p.m.)
Review request for mesos and Ben Mahler.
Changes
-------
Address BenM's comments.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
site/README.md 71ca3ebbc645c6c188223895d12fb436b55038f9
Diff: https://reviews.apache.org/r/43263/diff/
Testing
-------
Thanks,
Kapil Arya