You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/04 18:01:53 UTC
[GitHub] [beam] damccorm opened a new issue, #20507: Eliminate nullability errors from :sdks:java:core
damccorm opened a new issue, #20507:
URL: https://github.com/apache/beam/issues/20507
Just edit `build.gradle` and set `enableChecker: true` and fix some errors!
As of 2020-07-20 setting `-Xmaxerrs 10000` there are 1451 errors in the core Java SDK.
Imported from Jira [BEAM-10496](https://issues.apache.org/jira/browse/BEAM-10496). Original Jira may contain additional context.
Reported by: kenn.
Subtask of issue #20497
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on issue #20507: Eliminate nullability errors from :sdks:java:core
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on issue #20507:
URL: https://github.com/apache/beam/issues/20507#issuecomment-1438709761
@kennknowles do you have context here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aditya-mistri commented on issue #20507: Eliminate nullability errors from :sdks:java:core
Posted by "aditya-mistri (via GitHub)" <gi...@apache.org>.
aditya-mistri commented on issue #20507:
URL: https://github.com/apache/beam/issues/20507#issuecomment-1425906955
please assign me this issue , I want to work on this issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] HoussemNasri commented on issue #20507: Eliminate nullability errors from :sdks:java:core
Posted by "HoussemNasri (via GitHub)" <gi...@apache.org>.
HoussemNasri commented on issue #20507:
URL: https://github.com/apache/beam/issues/20507#issuecomment-1435779289
.take-issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] HoussemNasri commented on issue #20507: Eliminate nullability errors from :sdks:java:core
Posted by "HoussemNasri (via GitHub)" <gi...@apache.org>.
HoussemNasri commented on issue #20507:
URL: https://github.com/apache/beam/issues/20507#issuecomment-1435779241
As Aditya didn't respond to taking the issue, I assume he is no longer interested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on issue #20507: Eliminate nullability errors from :sdks:java:core
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on issue #20507:
URL: https://github.com/apache/beam/issues/20507#issuecomment-1425966056
Hey @aditya-mistri you can self assign issues by commenting `.take-issue`. That will trigger a github action to assign you. It may take a little bit depending on load on actions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] HoussemNasri commented on issue #20507: Eliminate nullability errors from :sdks:java:core
Posted by "HoussemNasri (via GitHub)" <gi...@apache.org>.
HoussemNasri commented on issue #20507:
URL: https://github.com/apache/beam/issues/20507#issuecomment-1435809958
Hey @damccorm, I built the project locally and everything seems to go fine, but I'm not sure where to put the `enableChecker: true`. As far as I understand, enableChecker should be passed to the beam gradle plugin. I have tried to pass it inside applyJavaNature closure but then loading gradle changes would fail. I also have tried to use enableSpotbugs instead, this time gradle reloads fine but compiling java files doesn't trigger the check to run.
I did more research and stamped upon this PR #13134 which seems to enable the checker framework for all modules/classes and disable it for certain classes that match a certain pattern. I figured since the Jira ticket was opened before the PR then the issue might need an update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on issue #20507: Eliminate nullability errors from :sdks:java:core
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on issue #20507:
URL: https://github.com/apache/beam/issues/20507#issuecomment-1438727866
Ah, the description is obsolete. Checker framework is enabled in all modules now. We automatically added `@SuppressWarnings("nullness")` to every class that had nullness errors. To work on this issue, find a class that has `@SuppressWarnings("nullness")` and remove that, then fix the errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on issue #20507: Eliminate nullability errors from :sdks:java:core
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on issue #20507:
URL: https://github.com/apache/beam/issues/20507#issuecomment-1438728529
Since checkerframework is integrated into compilation, all you have to do to get the errors is recompile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org