You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "codecov[bot] (via GitHub)" <gi...@apache.org> on 2023/08/09 21:38:58 UTC
[GitHub] [superset] codecov[bot] commented on pull request #24938: chore: Add explicit ON DELETE CASCADE for dashboard_slices
codecov[bot] commented on PR #24938:
URL: https://github.com/apache/superset/pull/24938#issuecomment-1672188129
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24938?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24938](https://app.codecov.io/gh/apache/superset/pull/24938?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (52caa1a) into [master](https://app.codecov.io/gh/apache/superset/commit/f6c3f0cbbb820b26ac9dc2f24832d59092a22f53?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f6c3f0c) will **decrease** coverage by `10.68%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 52caa1a differs from pull request most recent head b3fc170. Consider uploading reports for the commit b3fc170 to get more accurate results
```diff
@@ Coverage Diff @@
## master #24938 +/- ##
===========================================
- Coverage 69.00% 58.32% -10.68%
===========================================
Files 1906 1906
Lines 74145 74144 -1
Branches 8208 8208
===========================================
- Hits 51161 43245 -7916
- Misses 20861 28776 +7915
Partials 2123 2123
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `54.07% <ø> (+<0.01%)` | :arrow_up: |
| python | `61.04% <ø> (-22.33%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `55.04% <ø> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files Changed](https://app.codecov.io/gh/apache/superset/pull/24938?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [superset/daos/dashboard.py](https://app.codecov.io/gh/apache/superset/pull/24938?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvZGFvcy9kYXNoYm9hcmQucHk=) | `35.18% <ø> (-61.59%)` | :arrow_down: |
... and [293 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24938/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org