You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "Lunderberg (via GitHub)" <gi...@apache.org> on 2024/08/05 14:17:42 UTC
[PR] [FFI][Runtime] Use TVMValue::v_int64 to represent boolean values [tvm]
Lunderberg opened a new pull request, #17240:
URL: https://github.com/apache/tvm/pull/17240
This is a follow-up to https://github.com/apache/tvm/pull/16183, which added handling of boolean values in the TVM FFI. The initial implementation added both a new type code (`kTVMArgBool`) and a new `TVMValue::v_bool` variant. This commit removes the `TVMValue::v_bool` variant, since the `kTVMArgBool` type code is sufficient to handle boolean arguments.
Removing the `TVMValue::v_bool` variant also makes all `TVMValue` variants be 64-bit (assuming a 64-bit CPU). This can simplify debugging in some cases, since it prevents partial values from inactive variants from being present in memory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FFI][Runtime] Use TVMValue::v_int64 to represent boolean values [tvm]
Posted by "tqchen (via GitHub)" <gi...@apache.org>.
tqchen merged PR #17240:
URL: https://github.com/apache/tvm/pull/17240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FFI][Runtime] Use TVMValue::v_int64 to represent boolean values [tvm]
Posted by "Lunderberg (via GitHub)" <gi...@apache.org>.
Lunderberg commented on PR #17240:
URL: https://github.com/apache/tvm/pull/17240#issuecomment-2299206448
Fixed last two failing unit tests, since `MakePackedAPI` no longer needs to conditional load/convert a boolean to `int64`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FFI][Runtime] Use TVMValue::v_int64 to represent boolean values [tvm]
Posted by "Lunderberg (via GitHub)" <gi...@apache.org>.
Lunderberg commented on PR #17240:
URL: https://github.com/apache/tvm/pull/17240#issuecomment-2296629146
Rebased onto main, to rerun CI with the extra fixes after the revert/reapply of the FFI changes in https://github.com/apache/tvm/pull/17252 and https://github.com/apache/tvm/pull/17257.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org