You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafodion.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/01/04 01:36:00 UTC

[jira] [Commented] (TRAFODION-2875) Fix some inaccurate comparisons in analyzeMessageGuide.py

    [ https://issues.apache.org/jira/browse/TRAFODION-2875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16310577#comment-16310577 ] 

ASF GitHub Bot commented on TRAFODION-2875:
-------------------------------------------

GitHub user DaveBirdsall opened a pull request:

    https://github.com/apache/trafodion/pull/1367

    [TRAFODION-2875] Fix inaccuracies in comparison in analyzeMessageGuide.py

    Ignore trailing spaces in message text and documentation text.
    
    Take into account multiple substitution fields in message text and documentation text by replacing them with '.elided.' (before they were simply removed).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DaveBirdsall/trafodion Trafodion2875

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafodion/pull/1367.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1367
    
----
commit e349dea868a310679487d6b7a2244798107b35a4
Author: Dave Birdsall <db...@...>
Date:   2018-01-04T01:31:39Z

    [TRAFODION-2875] Fix inaccuracies in text comparison in analyzeMessageGuide.py

----


> Fix some inaccurate comparisons in analyzeMessageGuide.py
> ---------------------------------------------------------
>
>                 Key: TRAFODION-2875
>                 URL: https://issues.apache.org/jira/browse/TRAFODION-2875
>             Project: Apache Trafodion
>          Issue Type: Sub-task
>          Components: dev-environment
>         Environment: All
>            Reporter: David Wayne Birdsall
>            Assignee: David Wayne Birdsall
>            Priority: Minor
>
> The analyzeMessagesGuide.py script will declare a mismatch if there are differing numbers of trailing spaces in the message text as opposed to the documentation. The script should ignore such differences. The script also may incorrectly conclude that the message text matches the documentation when the message text ends with two substitution fields but the documentation only ends with one. This should be fixed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)