You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by jianjianjiao <gi...@git.apache.org> on 2018/11/01 19:58:03 UTC
[GitHub] spark pull request #22926: [SPARK-25917][Spark UI] memoryMetrics should be J...
GitHub user jianjianjiao opened a pull request:
https://github.com/apache/spark/pull/22926
[SPARK-25917][Spark UI] memoryMetrics should be Json ignored when being none
## What changes were proposed in this pull request?
Spark UI's executors page loads forever when memoryMetrics in None. Fix is to JSON ignore memorymetrics when it is None.
## How was this patch tested?
Before fix: (loads forever)
After fix:
That is because code in executorspage.js, Line 268
exec.memoryMetrics = exec.hasOwnProperty('memoryMetrics') ? exec.memoryMetrics : memoryMetrics;
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jianjianjiao/spark users/rotang/FixExecutorsPageLoadingForever
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22926.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22926
----
commit 5826424c931fbba81cc246c3b1afe3f64626e051
Author: Rong Tang <ro...@...>
Date: 2018-11-01T19:37:45Z
mmemoryMetrics should not json ignored when being none
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22926: [SPARK-25917][Spark UI] memoryMetrics should be Json ign...
Posted by jianjianjiao <gi...@git.apache.org>.
Github user jianjianjiao commented on the issue:
https://github.com/apache/spark/pull/22926
@mccheah, @smurakozi @vanzin Could you please help take a look at this PR? Thanks.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22926: [SPARK-25917][Spark UI] memoryMetrics should be Json ign...
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/22926
Is this a problem in master at all?
The data is serialized with `JacksonMessageWriter`, which seems to be configured properly:
```
private[v1] class JacksonMessageWriter extends MessageBodyWriter[Object]{
...
mapper.setSerializationInclusion(JsonInclude.Include.NON_ABSENT)
```
An easy way to answer that question is to write a unit test.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22926: [SPARK-25917][Spark UI] memoryMetrics should be Json ign...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22926
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22926: [SPARK-25917][Spark UI] memoryMetrics should be J...
Posted by jianjianjiao <gi...@git.apache.org>.
Github user jianjianjiao closed the pull request at:
https://github.com/apache/spark/pull/22926
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22926: [SPARK-25917][Spark UI] memoryMetrics should be Json ign...
Posted by jianjianjiao <gi...@git.apache.org>.
Github user jianjianjiao commented on the issue:
https://github.com/apache/spark/pull/22926
Thanks @vanzin . I was using 2.3, and with your comment, I found there was one check-in about one month ago that handled this case. Will close this PR, and sorry for the misreporting, I will keep in mind testing trunk before reporting next time.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22926: [SPARK-25917][Spark UI] memoryMetrics should be Json ign...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22926
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22926: [SPARK-25917][Spark UI] memoryMetrics should be Json ign...
Posted by jianjianjiao <gi...@git.apache.org>.
Github user jianjianjiao commented on the issue:
https://github.com/apache/spark/pull/22926
@AmplabJenkins Could you please find someone to review this? I believe this is a bug in Spark UI. Thanks.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22926: [SPARK-25917][Spark UI] memoryMetrics should be Json ign...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22926
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org