[jira] [Commented] (CLOUDSTACK-5654) router fails to plug nics in KVM VLAN isolation

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13857164#comment-13857164 ] 

ASF subversion and git services commented on CLOUDSTACK-5654:
-------------------------------------------------------------

Commit 8455a0677a8489a84767e01bba2f646339ea6cb2 in branch refs/heads/master from [~mlsorensen]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=8455a06 ]

CLOUDSTACK-5654: Don't pass empty string to BroadcastDomainType.Vlan.toUri
when attempting to parse VLAN/VNI from bridge's physical ethernet device


> router fails to plug nics in KVM VLAN isolation
> -----------------------------------------------
>
>                 Key: CLOUDSTACK-5654
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5654
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: KVM
>    Affects Versions: 4.3.0
>            Reporter: Marcus Sorensen
>            Assignee: Marcus Sorensen
>             Fix For: 4.3.0
>
>
> When vxlan was merged, it included getBroadcastUriFromBridge, which gets the vlan tag from the physical interface attached to the bridge. It looks for (\D)(\d)(\D*)(\d*). If a vxlan bridge is found (brvx), it returns the second element of this match as the broadcast id (VNI) by calling a "toUri" method. Otherwise, it returns the fourth element, which would be the vlan id if the device were something like 'eth0.200'. In situations where the bridge is untagged (eth0), however, it would throw an exception in trying to turn an empty string into a broadcast URI, causing any subsequent router setup to be canceled.
> We need to restore the old behavior of returning empty if no vlan id exists.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)