[GitHub] tillrohrmann commented on a change in pull request #6886: [BP-1.5][FLINK-10614] Let test_batch_allround.sh rely on test-runner-common.sh for clean up

[GitBox <gi...@apache.org>]

tillrohrmann commented on a change in pull request #6886: [BP-1.5][FLINK-10614] Let test_batch_allround.sh rely on test-runner-common.sh for clean up
URL: https://github.com/apache/flink/pull/6886#discussion_r226690899
 
 

 ##########
 File path: flink-end-to-end-tests/test-scripts/test_batch_allround.sh
 ##########
 @@ -24,31 +24,13 @@ TEST_PROGRAM_JAR=${END_TO_END_DIR}/flink-dataset-allround-test/target/DataSetAll
 echo "Run DataSet-Allround-Test Program"
 
 # modify configuration to include spilling to disk
-cp $FLINK_DIR/conf/flink-conf.yaml $FLINK_DIR/conf/flink-conf.yaml.bak
 echo "taskmanager.network.memory.min: 10485760" >> $FLINK_DIR/conf/flink-conf.yaml
 echo "taskmanager.network.memory.max: 10485760" >> $FLINK_DIR/conf/flink-conf.yaml
 
 backup_config
 
 Review comment:
   You're right, this command must be moved above the two `echo` lines. The config will be reverted by the `test-runner-common.sh`. With FLINK-10094 the backup moved to this script as well but it is not part of `release-1.5`. I will move this command before the two echos.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services